1812548 - Remove invalid wpt tests for `color()` with missing components

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Tiaan Louw [:tlouw]]

According to the specification, missing components are not allowed and the tests assume that those components are set to 0 if missing.

<predefined-rgb-params> = <predefined-rgb> [ <number> | <percentage> | none ]{3}

https://w3c.github.io/csswg-drafts/css-color-4/#color-function

Comment 1

[Tiaan Louw [:tlouw]]

Turns out this is not true and I was missing a section in the spec:

https://w3c.github.io/csswg-drafts/css-color-4/#missing

Comment 2

[Tiaan Louw [:tlouw]]

This bug requires some additional investigation.

Issue on the spec: https://github.com/w3c/csswg-drafts/issues/8362
Blink bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1410200
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=251152

Comment 3

[Tiaan Louw [:tlouw]]

Attachment: Bug 1812548 - Missing components in color() function is invalid r=emilio,#layout-reviewers

According to the specification, missing components in the color function
should result in an invalid color. This patch removes those tests from
valid checks and adds them to the invalid checks.

https://w3c.github.io/csswg-drafts/css-color-4/#missing

Comment 4

[Tiaan Louw [:tlouw]]

Issue clarified here: https://github.com/w3c/csswg-drafts/issues/8362

color() function with missing user-specified components is indeed a bug and needs to be fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/279c04f1ec04
Missing components in color() function is invalid r=emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38258 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/279c04f1ec04

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot