1812679 - `writing-mode: vertical-(lr|rl)` aligns at the center of box for baseline alignment no matter what

Status: VERIFIED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[David Shin[:dshin]]

Attachment: vertical-baseline.html

STR: See attached test case.
Expected: For both sets, "A" aligns with "DE."
Actual: "A" aligns to the center of the bordered box.

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1812679 - For central baseline, use calculated baseline for elements exporting baseline from its children. r=#layout-reviewers

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1812679 - Handle central baseline calculation in `GetNaturalBaselineBOffset`. r=#layout-reviewers

Previously, we simply found the center of content-box in
nsLineLayout::VerticalAlignFrames. However, this is incorrect for e.g. a div
with two lines of text where the central baseline should be the second line of
text.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49646b0d59aa
Handle central baseline calculation in `GetNaturalBaselineBOffset`. r=layout-reviewers,emilio

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in layout/style/test/test_revert.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | layout/style/test/test_revert.html | assertion count 0 is less than expected 3 assertions

Comment 6

[David Shin[:dshin]]

Hm, bug 1790201 expects it, but it no longer triggers.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11ba57726279
Handle central baseline calculation in `GetNaturalBaselineBOffset`. r=layout-reviewers,emilio

Comment 8

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/06d1305e3abc

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing Wr failures on text-combine-upright-value-all-002.html

Backout link

Push with failures

Failure log

Comment 10

[David Shin[:dshin]]

Fixed, checked all css-writing-modes/text-combine-upright WPT tests passing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/948c7217a313
Handle central baseline calculation in `GetNaturalBaselineBOffset`. r=layout-reviewers,emilio

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/948c7217a313

Comment 14

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-03-23 Nightly build on macOS 12.
Verified as fixed on Firefox 113.0(build ID: 20230501151611) and Nightly 114.0a1(build ID: 20230502160708) on macOS 12, Windows 10, Ubuntu 22.