1812703 - The app crashes when returning to the edit bookmarks menu after changing device settings

Status: NEW

(Firefox for Android :: Bookmarks, defect)

Description

[Jeff Boek [:boek]]

From github: https://github.com/mozilla-mobile/fenix/issues/21162.

Steps to reproduce

1. Open any website and add it to bookmarks
2. Open the Edit menu for that bookmark (either snackbar or 3-dot menu)
3. Open the device settings and toggle night mode
4. Wait for changes to take effect and return to Firefox

Expected behaviour

The application is stable at all times

Actual behaviour

The application crashes when returning to the edit menu after the changes take effect

Device name

Samsung Galaxy A8

Android version

Android 9

Firefox release type

Firefox

Firefox version

92.1.1 2021-09-04

Device logs

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fenix/org.mozilla.fenix.HomeActivity}: android.view.InflateException: Binary XML file line #27: Binary XML file line #27: Error inflating class fragment

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fenix/org.mozilla.fenix.HomeActivity}: android.view.InflateException: Binary XML file line #27: Binary XML file line #27: Error inflating class fragment
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3121)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3264)
at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5046)
at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:4955)
at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1955)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7078)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:964)
Caused by: android.view.InflateException: Binary XML file line #27: Binary XML file line #27: Error inflating class fragment
Caused by: android.view.InflateException: Binary XML file line #27: Error inflating class fragment
Caused by: kotlin.UninitializedPropertyAccessException: lateinit property binding has not been initialized
at org.mozilla.fenix.HomeActivity.getSupportActionBarAndInflateIfNecessary(HomeActivity.kt:16)
at org.mozilla.fenix.library.bookmarks.edit.EditBookmarkFragment.onViewCreated(EditBookmarkFragment.kt:3)
at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:30)
at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:24)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:73)
at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:5)
at androidx.fragment.app.FragmentStateManager.ensureInflatedView(FragmentStateManager.java:12)
at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:23)
at androidx.fragment.app.FragmentLayoutInflaterFactory.onCreateView(FragmentLayoutInflaterFactory.java:48)
at androidx.fragment.app.FragmentActivity.onCreateView(FragmentActivity.java:4)
at org.mozilla.fenix.HomeActivity.onCreateView(HomeActivity.kt:14)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:819)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:769)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:902)
at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:863)
at android.view.LayoutInflater.inflate(LayoutInflater.java:554)
at android.view.LayoutInflater.inflate(LayoutInflater.java:461)
at org.mozilla.fenix.perf.PerformanceInflater.inflate(PerformanceInflater.kt:4)
at android.view.LayoutInflater.inflate(LayoutInflater.java:383)
at androidx.appcompat.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:11)
at androidx.appcompat.app.AppCompatActivity.setContentView(AppCompatActivity.java:2)
at org.mozilla.fenix.HomeActivity.onCreate(HomeActivity.kt:18)
at android.app.Activity.performCreate(Activity.java:7327)
at android.app.Activity.performCreate(Activity.java:7318)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1275)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3101)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3264)
at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5046)
at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:4955)
at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1955)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7078)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:964)

Additional information

Occurs on Firefox Nightly 93.0a1 2021-09-06

Also triggers when changing other device settings such as navigation bar or font size.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Jeff Boek [:boek]]

Another stack trace: https://github.com/mozilla-mobile/fenix/issues/21162#issuecomment-1188972985

Comment 2

[Chris Peterson [:cpeterson]]

QA, is this bug still reproducible?

Comment 3

[Lorand Janos]

I wasn't able to reproduce this issue on the latest Nightly 111.0a1 (2023-01-27) with the following devices:

• Samsung Galaxy Tab S3 (Android 9) - as the closest device to the one this issue was originally reproduced with.
• Redmi 9C NFC (Android 10).
• Oppo Find X5 (Android 12).