181286 - Invalid html in banner.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Marcin Orlowski]

User-Agent:       telnet/80
Build Identifier: 

<DOCTYPE html....> shall be in the 1st line of the html document, while output
generated by  header.html.tmpl template is messed. We got this also 2 times
created (by code at line: 25 an then 37)

PS: Filed against bugzilla 2.16.1 templates

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Actual Results:  
malformed html

Expected Results:  
clean html

Comment 1

[Tobias Burnus]

Marcin Orlowski <[e-mail]> wrote:
> <DOCTYPE html....> shall be in the 1st line of the html document,
http://www.w3.org/TR/html4/struct/global.html#h-7.1 makes clear that even before
the <!DOCTYPE> comments, spaces and new lines are allowed. And looking at the
source of the generated html file on landfill (see url) it looks ok and validates.

> while output generated by  header.html.tmpl template is messed.
> We got this also 2 times created (by code at line: 25 an then 37)
Sorry I don't find anything like this neither in header.html.tmpl nor in the
produces output in the lines 25 and 37.

Comment 2

[Tobias Burnus]

Attachment: p1: banner.html.tmpl fix order of <font><center> to make is validate

When checking the HTML correctness I found that <font><center> had to be
swapped in order to be correct HTML 4 (index.cgi tested with
http://validator.w3.org).
This patch is against current 2.17[.1] CVS but affects also 2.16.1.

Comment 3

[Marcin Orlowski]

I've fetched the 2.16.1 again and verified. Your're right. header.html.tmpl here
does not contain doubled DOCTYPE specification. However, I've checked my
bugzilla setup and found, that there's data/ directory which contains some
templates as well, and it in fact holds invalud header.html.tmpl:

~: pwd
/home/bugzilla/bugzilla-2.16.1/data/template/en/default/global
~: fgrep -c DOCTYPE * | grep -v ":0$"
header.html.tmpl:2

So I wonder who's to blame? Perl template system? I got no idea (except 
it's runtime created) what creates data/  directory and what is the role
of it, but since I was freash bugzilla setup, it cannot be any old stuff
and it definitely is reladed (somehow) with this setup. Any ideas?

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 107037 [details] [diff] [review]
p1: banner.html.tmpl fix order of <font><center> to make is validate

The data/ stuff are the compiled templates. You may need to remove
data/template/ and rerun checksetup (2.17 checksetup always does this, rather
than trying to reuse the existing compiled stuff.)

Anyway, this patch is correct. Wonder why gmuck didn't complain....

r=bbaetz

Comment 5

[Bradley Baetz (:bbaetz)]

confirming, too

Comment 6

[Bradley Baetz (:bbaetz)]

-> patch author...

(and its banner.html.tmpl, not header.html.tmpl)

Comment 7

[Bradley Baetz (:bbaetz)]

..and fixed (YEs, I nkow this bug got morphed a bit)