Open Bug 1812886 Opened 2 years ago Updated 2 years ago

The Recently closed tabs counter is not updated before opening the list

Categories

(Firefox for Android :: Tabs, defect, P3)

All
Android
defect

Tracking

()

People

(Reporter: boek, Assigned: avirvara)

Details

From github: https://github.com/mozilla-mobile/fenix/issues/17523.

Steps to reproduce

  1. Launch Fenix;
  2. Open 2 or more tabs;
  3. Go to Tabs tray and close all the tabs one by one;
  4. Go to History;
  5. Observe the Recent closed tabs counter;

Expected behavior

The Recent closed tabs counter is updated with the number of tabs closed at steps 3.

Actual behavior

The Recent closed tabs counter is not updated with the number of tabs closed at steps 3. Is showing 1 tab less than the tabs closed.
When closing all the tabs with "Close all tabs", the number of tabs closed at the same time are not added to the Recently closed tabs counter.

Notes

The Recently closed tabs counter is updated after entering the list and leaving the list.

Device information

  • Android device: Motorola Moto G6 (Android 8), Samsung Galaxy Tab S3 (Android 8), Nexus 5 (Android 6.0.1).
  • Fenix version: Nightly 1/19

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Severity: -- → S3
Priority: -- → P3
Assignee: nobody → avirvara

I did a little bit of investigation on this issue and the conclusion is the following: the tabs are closed as they should and the counter works fine, whenever we close the tabs one by one, or by pressing the CloseAll button. The problem, however, appears because the time needed to update the closed tabs information into the storage is very long, and by the time we enter the History, the counter hasn't been updated yet, so it displays an incorrect value. Also, it is important to know that the number of recently closed tabs is now limited to a maximum of 10. Solving the issue might need some more serious thinking and refactoring, if it will be decided to go on with it.

You need to log in before you can comment on or make changes to this bug.