1812939 - PiP controls are not removed after adjusting subtitles font setting

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Ania]

Reproducible on macOS Monterey 12.4 and 12.5

STR

1. Launch a video with captions/subtitles on in a PiP.
2. Click the subtitles button in the PiP window, and change the
   font size. Click on the video to close the subtitles settings panel.
3. Stop hovering over the PiP window.

Expected result
PiP playback controls disappear once the user starts hovering over the PiP window.

Actual result
PiP playback controls remain visible until the PiP window is closed or unpopped.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1812939 - Remove donthide attribute from controls when hiding subtitles settings. r=cmkm,#pip-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9d22ed07b44
Remove donthide attribute from controls when hiding subtitles settings. r=pip-reviewers,mhowell

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c9d22ed07b44

Comment 5

[Daniel Bodea [:danibodea]]

This behavior appears to be fixed in Nightly v112.0a1 in Windows 10, MacOS 11 and Ubuntu 22.
Should this fix be considered for uplift?

Comment 6

[Niklas Baumgardner [:niklas]]

I don't think this requires an uplift

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.