1813008 - [wpt-sync] Sync PR 38217 - [css-nesting] Make selectors dropped during forgiving parsing still count towards nest-containment.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38217 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38217
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

[css-nesting] Make selectors dropped during forgiving parsing still count towards nest-containment.

Also add a test. We keep track of this using a simple boolean,
and since we make CSSParser from scratch every time we start parsing
a new top-level selector, we don't need to worry about resetting it.

In line with CSSWG resolution at
https://github.com/w3c/csswg-drafts/issues/7972.

Bug: 1095675
Change-Id: I869e6859e32284167ef4e1e8c60b64e770b9e945

Reviewed-on: https://chromium-review.googlesource.com/4200218
WPT-Export-Revision: f3b18dabd9b56b29b2e7fe43db651e41d5458221

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b8869b12b4319b07cdf86ce5d62e479daa5e257

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-nesting/nest-containing-forgiving.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/646b386e306a
[wpt PR 38217] - [css-nesting] Make selectors dropped during forgiving parsing still count towards nest-containment., a=testonly
https://hg.mozilla.org/integration/autoland/rev/ebeb88153be0
[wpt PR 38217] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/646b386e306a
https://hg.mozilla.org/mozilla-central/rev/ebeb88153be0