1813129 - Firefox should fall back if staging fails with a memory error

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Robin Steuber (she/her) [:bytesized]]

The updater needs to allocate memory in order to stage an update. We have several specific error codes for when staging fails due to inability to allocate memory. It looks like we currently react to these errors the way that we react to most errors: by clearing out the update and attempting to download another one.

But there is something that we should keep in mind when this happens. Staging means installing an update specifically while Firefox is running, and Firefox uses a lot of memory. If we failed to allocate sufficient memory to update when Firefox was running, we should try again when Firefox is not running. This is to say that when we get a memory error while staging, we should fall back to updating without staging.

Comment 1

[Nick Alexander :nalexander [he/him]]

But there is something that we should keep in mind when this happens. Staging means installing an update specifically while Firefox is running, and Firefox uses a lot of memory. If we failed to allocate sufficient memory to update when Firefox was running, we should try again when Firefox is not running. This is to say that when we get a memory error while staging, we should fall back to updating without staging.

This would just fall back to not staging for this particular update, correct? And then the next update cycle would respect the existing in-Gecko preferences?

Comment 2

[Robin Steuber (she/her) [:bytesized]]

(In reply to Nick Alexander :nalexander [he/him] from comment #1)

This would just fall back to not staging for this particular update, correct? And then the next update cycle would respect the existing in-Gecko preferences?

That's correct.

Comment 3

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1813129 - Fall back from memory errors during staging r=nalexander!

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1813129 - Test for fallback on memory allocation error r=nalexander!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f96a4c0174ee
Fall back from memory errors during staging r=nalexander
https://hg.mozilla.org/integration/autoland/rev/6c309593a0f9
Test for fallback on memory allocation error r=nalexander

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f96a4c0174ee
https://hg.mozilla.org/mozilla-central/rev/6c309593a0f9