1813189 - `image-rendering: crisp-edges/pixelated` don't work anymore for `VIDEO` with AMD GPU since Firefox 110.0a1 20221220214632

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Marat Tanalin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

CSS image-rendering: crisp-edges and image-rendering: pixelated stopped working with AMD GPU since Firefox 110.0a1 build 20221220214632.

The previous build 20221220093956 was NOT affected.

Test with any video on YouTube, with Firefox Developer Tools. Use 240p quality to clearly see whether the video is pixelated (image-rendering: crisp-edges/pixelated works) or blurry (image-rendering does not work).

GPU model and driver & Windows versions:

• GPU: AMD Radeon RX 550 (MSI Radeon RX 550 AERO ITX 4G OC).
• AMD driver (AMD Software: Adrenalin Edition) version: 22.11.1 (2022-11-10).
• Windows version according to winver: 21H2 (OS Build 19044.2486)

The issue apparently does not reproduce with nVidia GPU under Windows 7 (GTX 650 Ti Boost, Gigabyte GV-N65TBOC-2GD).

Comment 1

[Marat Tanalin]

The issue affects VIDEO elements, not IMG elements.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Gregory Pappas [:gregp]]

Reporter, If you think this is a regression, please try to find a regression range with mozregression.

Comment 4

[Marat Tanalin]

I don’t know how to use mozregression for now. I provided the exact build that introduced the issue (I downloaded different builds and tested one by one) — I suspect this should be precise enough.

Comment 5

[Alice0775 White]

Regression window:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d0f5d55312bf95b2d4ba869cf5dea2535098958b&tochange=b3c753122e8d894d2765fecc5e99c7ff49bdaec2

Regressed by Bug 1758601 on nightly builds, and seems by bug 1798245 on release builds.

Workaround: set gfx.webrender.dcomp-video-overlay-win to false in about:config.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

:sotaro, since you are the author of the regressor, bug 1758601, could you take a look?

For more information, please visit auto_nag documentation.

Comment 7

[Sotaro Ikeda [:sotaro]]

Hi Marat Tanalin, can you attach about:support to this bug? Thank you.

Comment 8

[Alice0775 White]

Attachment: about:support

about:support

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox110 (beta) and tracked for firefox111 (nightly). We have limited time to fix this, the soft freeze is in 9 days. However, the bug still isn't assigned and has low severity.

:bhood, could you please find an assignee and increase the severity for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 10

[Bob Hood [:bhood]]

Sotaro, dropping this on your plate for now. When you have some cycles, please see if there's any insights you can provide.

Comment 11

[Sotaro Ikeda [:sotaro]]

I confirmed that that the problem exists also on intel GPU on my Windows11 PC. When video overlay is used, it seemed not care about interpolation mode of IDCompositionVisual. Video overlay on intel GPU is already enabled until release.

https://searchfox.org/mozilla-central/rev/02ff1234547a8097df4b07a0deb70dae49ac0d03/gfx/webrender_bindings/DCLayerTree.cpp#668

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1813189 - Limit external compositing only to ImageRendering::Auto

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73b3d6ed8031
Limit external compositing only to ImageRendering::Auto r=gw,gfx-reviewers

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/73b3d6ed8031

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Marat Tanalin]

Can confirm the bug does not reproduce in the latest beta Firefox 110.0b9 (20230202190127) (Developer Edition). Hopefully the issue won’t leak into stable release too. Thanks.

Comment 17

[Sotaro Ikeda [:sotaro]]

Good. Thank you for the confirmation!

Comment 18

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9315310 [details]
Bug 1813189 - Limit external compositing only to ImageRendering::Auto

Beta/Release Uplift Approval Request

• User impact if declined: image-rendering: crisp-edges/pixelated don't work for VIDEO with non-Intel GPU. Though the problem already exists with Intel GPU on Release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch just disable video overlay with image-rendering: crisp-edges/pixelated.
• String changes made/needed: none
• Is Android affected?: No

Comment 19

[Pascal Chevrel:pascalc]

Comment on attachment 9315310 [details]
Bug 1813189 - Limit external compositing only to ImageRendering::Auto

I am taking it to the beta branch before the merge and building our RC as this is a low risk fix for a regression caused by a feature we are activating in 110, thanks!

Comment 20

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/84d001b9b5ed