1813202 - Pop-up blocker: better bottom sheet design

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, enhancement)

Description

[Jeff Boek [:boek]]

From github: https://github.com/mozilla-mobile/fenix/issues/6973.

User Problem

When a user opens a page that tries to open pop-ups, the user is presented the message "Prevent this site from opening a pop-up window?" followed by the URL of the page and the buttons "DENY" and "ALLOW". These two answers are confusing. If I "allow", do I allow pop-ups, or do I allow Firefox to block them? If I "deny", do I deny Firefox the possibility to block them, or do I deny the page the possibility to open them?

Solution

Change the answers to the shorter, simpler and non-ambiguous "yes" and "no". And maybe not write them all in capitals, as they are now. Why shout?

(PS: this feature request is midway between a feature request and a bug report.)

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[jscher2000]

There's a fresh complaint on Mozilla Connect that the buttons labels in this dialog don't make sense for the question:

Question: Prevent ... ?

Answer A: DENY

Answer B: ALLOW

If the answers can't be changed, how about changing the question to make sense with the answers?

Ref. https://connect.mozilla.org/t5/discussions/deny-the-prevention-or-allow-the-prevention-or-what-pop-up/td-p/53976

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1813202 - Remove ambiguity whether "Allow/Deny" apply to the site's permission to open pop-ups or Firefox's prevention of the popup. r=boek

Comment 3

[Nick Rishel [:nrishel]]

After discussing this with UX on Slack and during their office hours, we settled on clarifying and simplifying this message to Allow this site to open? which in context is followed by a link to the URL to open and the options Allow and Deny. Notably we've elided referring to this as a popup given that popups and new tabs are indistinguishable from a user perspective on mobile.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db60a8307047
Remove ambiguity whether "Allow/Deny" apply to the site's permission to open pop-ups or Firefox's prevention of the popup. r=boek,android-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/db60a8307047