Closed Bug 1813226 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 38237 - [GridNG] Handle opposite writing modes in named line resolution

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38237 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38237
Details from upstream follow.

Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com> wrote:

[GridNG] Handle opposite writing modes in named line resolution

When named grid lines are merged, opposing writing modes from
grid->subgrid should be flipped when building up the merged list. The
rest of the grid layout pipeline handles the actual writing mode layout
differences.

This also fixes a small bug we had, where duplicated entries were not
being removed from the merged list.

Bug: 618969
Change-Id: If4d60e9b96078b944736e46737e9e9e5a5f423db
Reviewed-on: https://chromium-review.googlesource.com/4195851
WPT-Export-Revision: 329878cde9acc8986365ac583de61f816b7674d9

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06d322e6d707 [wpt PR 38237] - [GridNG] Handle opposite writing modes in named line resolution, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/06d322e6d707

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.