181324 - jsfile.c buggy on Windows

Status: RESOLVED DUPLICATE of bug 132949

(Core :: JavaScript Engine, defect, P3)

Description

[Brendan Eich [:brendan]]

Patch from Mladen Turk <[e-mail]> coming up.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: Mladen's patch

Comment 2

[timeless]

Comment on attachment 107046 [details] [diff] [review]
Mladen's patch

-		 if (*tmp) {
+		 if (strlen(tmp)>0) {
unless jsengine really likes wasting cycles, please don't do this.
we just landed a patch to remove useless operations like it.

In fact, you can change:
     if ((strlen(pathname)>=2)&&(pathname[1]==':')) {
to
if (pathname[0] && pathname[1]==':' && pathname[2])

Comment 3

[Brendan Eich [:brendan]]

Mladen, I hope you're willing to take this bug and address comment #2.  If not,
timeless or I will get to it, but it's not as high priorty for us as for you,
I'm sure.  I'll check the patch in when it's ready.

/be

Comment 4

[Phil Schwartau]

Also note bug 132949,
"Uninitialized pointer used in function call in jsfile.c"

That has a proposed patch from [e-mail].

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Marking as a DUPE of a bug with a much more comprehensive patch.

*** This bug has been marked as a duplicate of 132949 ***