1813275 - Extension installation doorhanger extends to right, outside the Firefox window's boundary

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: Beta_110_vs_Nightly_111_screenshot.png

Will, this bug is a regression in 111 from your unified extension changes in bug 1799009. I bisected this regression to this pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a42619299cf2955dbd38d16cc7ac0f64ee92eb78&tochange=91a26c6b212aaf351dd06c07cd4ee172af902bb1

Steps to reproduce

1. Load an extension's AMO page, e.g. https://addons.mozilla.org/en-US/firefox/addon/tomato-clock/
2. Resize your Firefox window so it's not maximized.
3. Click the "Add to Firefox" button.

Expected result

The extension doorhanger should drop down and to the left of the unified extension button.

Actual result

The extension doorhanger drops down and to the right of the unified extension button, extending outside the Firefox window's boundary. See the attached screenshot.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1813275 - Fix extension installation doorhanger position. r?rpl!

This was regressed by mistake in Bug 1799009.

Comment 2

[William Durand [:willdurand]]

Thanks for the detailed bug report, it was trivial to spot my mistake... I do wonder if this is why we saw an increase in intermittents recently (Bug 1789607).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a0b8b7f1cab
Fix extension installation doorhanger position. r=rpl

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8a0b8b7f1cab