1813292 - [wpt-sync] Sync PR 38239 - Allow speculative parser to see inside DSD templates

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38239 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38239
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Allow speculative parser to see inside DSD templates

Prior to this CL, the speculative parser would bail out at the sight
of any \<template> element. However, if that template was a DSD
shadow root, like \<template shadowrootmode=open>, it should be
scanned.

Note that DSD shadow roots inside "normal" template elements
should still be skipped, since everything in the \<template>
is inert.

I also updated the speculative parser script to not blow away all
files, but instead just remove the .html files.

Bug: 1379513
Change-Id: I0ee8d64d9c33905f9fb1c5a0f5b4f428858c403a
Fixed: 1410933
Reviewed-on: https://chromium-review.googlesource.com/4200836
WPT-Export-Revision: 6353225ddee203ae0f7cb194ba85a644b182ae9e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=334e1048090dcf2c2c7378266bb86e7adae1dd41

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 120 tests and 1 subtests

Status Summary

Firefox

OK : 120
PASS: 103[Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt] 104[Gecko-windows10-32-2004-qr-debug] 105[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-2004-qr-debug, GitHub]
FAIL: 15[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-2004-qr-debug, GitHub] 16[Gecko-windows10-32-2004-qr-debug] 17[Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt]

Chrome

OK : 120
PASS: 85
FAIL: 35

Safari

OK : 120
PASS: 75
FAIL: 45

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-unsupported-type.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): link-rel-stylesheet-unsupported-type: FAIL linked bug:Bug 1732333
• /html/syntax/speculative-parsing/generated/document-write/template-img-src.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): template-img-src: FAIL
• /html/syntax/speculative-parsing/generated/page-load/link-rel-stylesheet-unsupported-type.tentative.html [wpt.fyi]
  • Speculative parsing, page load: link-rel-stylesheet-unsupported-type: FAIL linked bug:Bug 1733699
• /html/syntax/speculative-parsing/generated/page-load/template-img-src.tentative.html [wpt.fyi]
  • Speculative parsing, page load: template-img-src: FAIL

New Tests That Don't Pass

• /html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-disabled.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): link-rel-stylesheet-disabled: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-nomatch-media.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): link-rel-stylesheet-nomatch-media: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-unsupported-type.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): link-rel-stylesheet-unsupported-type: FAIL (Chrome: PASS, Safari: PASS)
• /html/syntax/speculative-parsing/generated/document-write/meta-viewport-link-stylesheet-media.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): meta-viewport-link-stylesheet-media: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/document-write/template-img-src.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): template-img-src: FAIL (Chrome: PASS, Safari: PASS)
• /html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-link-stylesheet.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): template-shadowrootmode-link-stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-script-src.tentative.sub.html [wpt.fyi]
  • Speculative parsing, document.write(): template-shadowrootmode-script-src: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/page-load/img-srcset.tentative.html [wpt.fyi]
  • Speculative parsing, page load: img-srcset: FAIL [Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-2004-qr-debug, GitHub] (Chrome: PASS, Safari: PASS)
• /html/syntax/speculative-parsing/generated/page-load/link-rel-stylesheet-disabled.tentative.html [wpt.fyi]
  • Speculative parsing, page load: link-rel-stylesheet-disabled: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/page-load/link-rel-stylesheet-nomatch-media.tentative.html [wpt.fyi]
  • Speculative parsing, page load: link-rel-stylesheet-nomatch-media: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/page-load/link-rel-stylesheet-unsupported-type.tentative.html [wpt.fyi]
  • Speculative parsing, page load: link-rel-stylesheet-unsupported-type: FAIL (Chrome: PASS, Safari: PASS)
• /html/syntax/speculative-parsing/generated/page-load/meta-charset-script-src.tentative.html [wpt.fyi]
  • Speculative parsing, page load: meta-charset-script-src: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/page-load/meta-viewport-link-stylesheet-media.tentative.html [wpt.fyi]
  • Speculative parsing, page load: meta-viewport-link-stylesheet-media: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/page-load/picture-source-br-img.tentative.html [wpt.fyi]
  • Speculative parsing, page load: picture-source-br-img: FAIL [Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug, GitHub] (Chrome: FAIL, Safari: PASS)
• /html/syntax/speculative-parsing/generated/page-load/template-img-src.tentative.html [wpt.fyi]
  • Speculative parsing, page load: template-img-src: FAIL (Chrome: PASS, Safari: PASS)
• /html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-link-stylesheet.tentative.html [wpt.fyi]
  • Speculative parsing, page load: template-shadowrootmode-link-stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-script-src.tentative.html [wpt.fyi]
  • Speculative parsing, page load: template-shadowrootmode-script-src: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e13f3915542d
[wpt PR 38239] - Allow speculative parser to see inside DSD templates, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7eb73286f669
[wpt PR 38239] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e13f3915542d
https://hg.mozilla.org/mozilla-central/rev/7eb73286f669