Tweak expiration of favicons older than 180 days
Categories
(Toolkit :: Places, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently we're expiring favicons older than 180 days, for redirects and ref pages having a root icon.
First, the 180 days are checked against the icon, but some time ago we moved expiration of non root icons to the moz_icons_to_pages table, so what we should actually check is pages that have only relations older than 180 days.
Second, the selection is too lenient, we can be a bit more aggressive. In telemetry I see a 6% of databases > 50MiB and I'd prefer to reduce that number a bit, considering we keep places.sqlite ~70MiB. By reducing the DB size we'll gain on efficiency for data that actually matters.
Thus I'm suggesting that we expire any relation older than 180 days if the page is not bookmarked, and we have a root icon for the page origin.
|
Assignee | |
Comment 1•1 year ago
|
||
Expire page <-> icon relations older than 180 days if the page is not bookmarked
and there is a root icon for the page's origin.
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/66ff53f1a7c8 Tweak expiration of favicons older than 180 days. r=Standard8
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Description
•