DOGFOOD: relative URLs do not resolve correctly from web-based pages (FILE: access o.k.)

VERIFIED FIXED in M11

Status

()

Core
Networking
P3
major
VERIFIED FIXED
19 years ago
19 years ago

People

(Reporter: rxsherm, Assigned: Judson Valeski)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [PDT+], URL)

Attachments

(2 attachments)

(Reporter)

Description

19 years ago
Given the following HTML :

<html>
<a href="../../helloworld.html">hello world that doesnt resolve URL
properly</a><br>
</html>

The relative link above will not resolve properly if this page is retrieved from
a web server (HTTP:-prefixed) URL. (If this page is retrieved from a FILE: path,
it works o.k.)

In Mozilla, the URL not only displays incorrectly when highlighted (it appears
as http://helloworld.html) but when clicked, the browser attempts to connect to
the bad URL.
*** Bug 18202 has been marked as a duplicate of this bug. ***
*** Bug 18202 has been marked as a duplicate of this bug. ***
Assignee: leger → gagan
Component: Browser-General → Necko

Updated

19 years ago
QA Contact: leger → tever

Comment 3

19 years ago
tever, can you try with latest build and give your results.  Thanks!

Comment 4

19 years ago
Hmm... this looks like a regression.

Comment 5

19 years ago
Oooppss ... ok this is very much likely the new resolve stuff. We no longer
handle the path independly before exposing it to RelpaceMess. So the ../..
leakes into the host, when there are more .. than directory depth.

Comment 6

19 years ago
Created attachment 2710 [details] [diff] [review]
This should solve the problem, Judson is just testing it.

Comment 7

19 years ago
Created attachment 2717 [details] [diff] [review]
Another try without memory alloc
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 8

19 years ago
andreas' latest patch fixes this (I verified it). Test case (internal) at URL in
URL field. You should be able to click on the link and goto a page two dirs deep
with the text "Got it!"

Updated

19 years ago
Summary: relative URLs do not resolve correctly from web-based pages (FILE: access o.k.) → DOGFOOD: relative URLs do not resolve correctly from web-based pages (FILE: access o.k.)

Comment 9

19 years ago
This breaks links inside of tinderbox if you're accessing it through
<http://tinderbox.mozilla.org/> rather than
<http://cvs-mirror.mozilla.org/tinderbox/>.  This probably has the potential to
break a non-trivial number of web pages... seems like good M11 fodder, given
that it's a regression and Andreas has already been kind enough to submit a
patch.
(Assignee)

Updated

19 years ago
Target Milestone: M11
(Assignee)

Comment 10

19 years ago
agreed. m11 approval?
(Assignee)

Comment 11

19 years ago
added new test case url (old http server wasn't working properly). same steps to
verify
(Assignee)

Updated

19 years ago
Assignee: gagan → valeski
Status: ASSIGNED → NEW

Updated

19 years ago
Blocks: 13449

Updated

19 years ago
Whiteboard: [PDT+]

Comment 12

19 years ago
Putting on PDT+ radar.  chofmann believes the fix was checked in.  Is this
fixed?
The tinderbox case, at least, now works correctly.
(Assignee)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 14

19 years ago
fix checked in a few hours ago. sorry about that.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 15

19 years ago
Verified on 11/23 build. Various levels of relative URLs tested.

Updated

19 years ago
Status: VERIFIED → REOPENED

Comment 16

19 years ago
Shows correctly, but when cliking on some link in the page the image dissapers.

Load http://www.avp.ee

Look at the banner on the top of the screen, click a link on the page, the
banner dissapers, when all other is still shown.

I do not know may I or not to make chainges in status, but I do it. If not write
to me, please.

Updated

19 years ago
Status: REOPENED → RESOLVED
Last Resolved: 19 years ago19 years ago

Comment 17

19 years ago
What you describe is an entirely different problem, it is covered in bug 18790.
The problem described in this bug is still fixed. So I'm closing this one again.

Comment 18

19 years ago
Bulk move of all Necko (to be deleted component) bugs to new Networking

component.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 19

19 years ago
works fine on all platforms (14th's build). marking verified.

Comment 20

19 years ago
works fine on all platforms (14th's build). marking verified.
You need to log in before you can comment on or make changes to this bug.