1813427 - The tip of the TCP CFR message doesn’t point to the lock button from the Address Bar

Status: VERIFIED FIXED

(Firefox for Android :: Experimentation and Telemetry, defect)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/fenix/issues/27662.

Steps to reproduce

[Prerequisites]:

• Have a local Beta build that is set-up to point to the Nimbus Prod server: link
• Have the local build installed on a device.

[Steps to reproduce]:

1. Open the local build from the prerequisites.
2. Navigate to the Firefox "Settings" menu.
3. Scroll down to the bottom of the list and tap the "About Firefox Beta" option.
4. Tap the "Firefox Browser" logo 5 times and go back to the "Settings" menu.
5. Scroll down to the bottom of the list and tap the "Secret Settings" option.
6. Enable the “Use Nimbus Preview Collection” option and restart the browser.
7. Navigate again to the Firefox "Settings" menu -> "About Firefox Beta" option.
8. Tap the "Firefox Browser" logo 5 times and go back to the "Settings" menu.
9. Scroll down to the bottom of the list and tap the "Nimbus Experiments" option.
10. Tap the "Firefox Android TCP CFR Experiment" experiment.
11. Tap the “treatment-a” branch and restart the browser.
12. Navigate to a website and observe the TCP CFR message.

Expected behaviour

• The tip of the TCP CFR message points to the lock button from the Address Bar.

Actual behaviour

• The tip of the TCP CFR message does not point to the lock button from the Address Bar.

Device name

Samsung S9, One Plus 6, Samsung S8

Android version

Android 9, Android 10, Android 11

Firefox release type

Firefox Beta

Firefox version

107.0b6

Device logs

No response

Additional information

• The issue is also reproducible when the device is in landscape mode.
• The issue is reproducible with both the Address Bar being displayed to the bottom or to the top of the screen.
• Here are 2 screenshots of the issue:

┆Issue is synchronized with this Jira Task
┆Link To Issue: https://mozilla-hub.atlassian.net/browse/FNXV2-21914

Change performed by the Move to Bugzilla add-on.

Comment 1

[Chris Peterson [:cpeterson]]

See the GitHub issue for a screenshot:

https://github.com/mozilla-mobile/fenix/issues/27662#issue-1433145539

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Open PR waiting for review - https://github.com/mozilla-mobile/firefox-android/pull/524

Comment 3

[Chris Peterson [:cpeterson]]

PR was just merged:

https://github.com/mozilla-mobile/firefox-android/commit/37975a975761b2f768ef800b6e9b242e3f4a63bc

Comment 4

[Petru-Mugurel Lingurar [:petru]]

@QA The merged patch refactors all CFRs. Please ensure they are showing fine (with a Focus on the TCP CFR) including on devices with gesture navigation enabled and under display cameras.

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 111.0a1 2015932491, b71995e8e+, AC: 111.0.20230209143246, 25ac5dfdbf, GV: 111.0a1-20230209041032, AS: 96.4.0 using the following devices:

• Samsung S9, Android 10
• Oneplus 6, Android 11
• Samsung Galaxy S23 Ultra, Android 13
• Samsung Galaxy S21 Plus, Android 13
• Samsung Fold 4, Android 13

-> The TCP CFR tip is pointing to the lock button from the Address Bar.
-> The Jump Back In and Synced Tab CFRs are correctly displayed and placed on the screen.
-> All the messages were verified using button and gestures navigation, portrait and landscape mode. Also, for the TCP CFR, I verified that the message is correctly displayed on devices with in and under-display cameras.
-> While verifying this issue, I encountered an edge case that affects the Synced Tab CFR, for which I filed Bug 1816130.