1813526 - [US][gopro.com/] Form autofill/preview/clear are only applied on the selected field

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Hani Yacoub, Desktop QA]

Found in

• 111.0a1 (2023-01-29)

Affected versions

• 111.0a1, 110.0b9, 109.0

Tested platforms

• Affected platforms: Windows 10, macOS 11

Preconditions

• Have at least one CC already saved
• browser.search.region US

Steps to reproduce

1. Reach the payment form on www.gopro.com
2. Click on the name field
3. Click on "Card Number" or "Expiry Date" fields and observe the autofill preview
4. Select any of the options for the dropdown and observe if autofill is applied
5. Right click on "Card Number" or "Expiry Date" fields and choose "Clear autofill form"

Expected result

• Form autofill/preview/clear should be applied on eligible fields

Actual result

• Form autofill/preview/clear are only applied on the selected field

Regression range

• Not a recent regression.

Additional notes

• Not reproducible on Chrome.

Comment 1

[Hani Yacoub, Desktop QA]

I've retested this on the latest Nightly 132.0a1 on macOS 14.

• Triggering autofill from “CC number” and “Date” fields is autofilling all fields
• Clearing autofill from “CC number” and “Date” fields isn’t clearing “Name” field
• Triggering autofill from “Name” field is only autofilling “Name” field
• Clearing autofill from “Name” field is only clearing “Name” field

When the extensions.formautofill.heuristics.autofillSameOriginWithTop setting is set to true, clearing autofill from any field is clearing all the targeted fields.

It seems that the "Card Name" field is situated on the main page, and not inside an iframe, unlike the 'Card Number' and 'Expiry Date' fields which are located within same-origin iframes.

Comment 2

[Hani Yacoub, Desktop QA]

Attachment: Screenshot 2024-09-05 at 12.17.57.png

Comment 3

[Hani Yacoub, Desktop QA]

Attachment: Screen Recording 2024-09-05 at 12.29.43.mov

Comment 4

[Dimi Lee [:dimi]]

Hi Hani, just to confirm, so if we set extensions.formautofill.heuristics.autofillSameOriginWithTop to true, everything works as expected?

Comment 5

[Hani Yacoub, Desktop QA]

Hi Dimi, just the clear autofill form works as expected if we set that pref to true. Triggering autofill from “Name” field is only autofilling “Name” field.

Comment 6

[Dimi Lee [:dimi]]

(In reply to Hani Yacoub, Desktop QA from comment #5)

Hi Dimi, just the clear autofill form works as expected if we set that pref to true. Triggering autofill from “Name” field is only autofilling “Name” field.

Thank you for the quick reply! Yes, This the expected behavior after setting extensions.formautofill.heuristics.autofillSameOriginWithTop to true. The reason is that when you trigger autofill from the main-frame, we will not autofill a cross-origin iframe, which in this case is cc-number and cc-exp

Comment 7

[Alin Ilea, Desktop Test Engineering]

Fixed by bug 1916606. The CC Name field that is located in the main frame, is now autofilled and cleared accordingly.
As we agreed with the engineering team and based on this comment, I will mark this as fixed and verified.
Just as a note, not all the CC fields are highlighted with the specific autofill yellow color (only the CC Name that is in the main frame is highlighted).