Closed Bug 1813545 Opened 1 year ago Closed 1 year ago

FF not responding for about a minute after PC wake from sleep

Categories

(Toolkit :: Places, defect)

x86_64
Windows 10
defect

Tracking

()

RESOLVED DUPLICATE of bug 1818461
Performance Impact ?

People

(Reporter: ezh, Unassigned)

Details

Attachments

(5 files)

I have about 12 Windows PC's/notebooks I use (on every place on work/home/summer house I have a different PC). After I wake the PC from sleep and start using FF, it would fall into not responding state. In about a minute all is fine again. Same behavior on all systems. Sync is on. Sometimes it happens just using FF.

What logs should I provide to find the cause out?

tnx

Attached image ff-not-responding.png

Sometimes it happens just using FF as well. For example just now I saw this:

  • FF stopped responding
  • vertical Windows taskbar I use on the left edge disappears under the FF window
  • on the right side of the screen with same width came the Windows 7 theme buttons up
Attached image task manager screenshot

At that moments the CPU cooler starts to blow, Task Manager shows "Very high" by power usage and the memory usage begins to rise. After that it falls to 680mb (this time).

Just got it again, starting FF. Memory goes rapidly up to 4,8gb, then goes does down to 700mb and FF is again usable.

Attached image image.png

Anybody? It drives me crazy... Cannot work normally.

I just manually synced FF and got the same not responding state. So, it seems to be affected by syncing.

Attached image image.png

Manually forced FF to sync and got a hang.

Attached image image.png

I had Process Hacker open and got the hang. You may see the memory consumption & I/O grow.

Performance Impact: --- → ?
Component: General → Performance
Product: Firefox → Core

I strongly suspect this is related to some website queuing up a large amount of timeouts or an other form of events that accumulate over time. However this should only impact a content process I believe. Could you go to https://profiler.firefox.com/ and create a profile of this occurring. You may have to start the profiler before putting the machine to sleep and end it after Firefox resumes responding in order to capture this problem.

Flags: needinfo?(ezh)
Flags: needinfo?(ezh)

Started PC and just in time pressed the profiler, after some ms it hanged. So there must be the right case saved.

The profile captures the problem perfectly. Nice!

The delay occurs when a list of bookmarks is computed to be displayed somewhere in the UI. Do you have a lot of bookmarks in the bookmarks toolbar? Or do you have the Bookmarks library window open?

Component: Performance → Places
Product: Core → Toolkit
Version: unspecified → Trunk

It looks to me like maybe this is being kicked off because of a Sync operation in resource://gre/modules/SyncedBookmarksMirror.sys.mjs: https://searchfox.org/mozilla-central/rev/dcf64fc565e3749119bd57202e2ab06533155d16/toolkit/components/places/SyncedBookmarksMirror.sys.mjs#2402-2410

Hey mak, I seem to recall some recent work around providing more performant, off-main-thread APIs for things like this. Am I misremembering? Is there something better that SyncedBookmarksMirror should be doing?

Flags: needinfo?(mak)

Yes. I do have a lot of bookmarks on the bookmarks toolbar.

Thank you for the profile!

It looks like a duplicate of Bug 1818461, the problem is not just Sync or Places doing a large operation, but it's things observing Places doing synchronous work inside the notifications.
There's absolutely no reason to update the bookmarks toolbar empty message this often, and moreover using synchronous IO during the notification itself (that is where most of the time is spent here, unpredictable I/O probably causing some thread contention).
That's what Bug 1818461 is tracking, we can make that a ton more efficient.

There's another offender in the New Tab page too, I am tracking those as blocking bug 1533061.

Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1818461
Flags: needinfo?(mak)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: