Closed Bug 1813559 Opened 1 year ago Closed 1 year ago

Do not bail out too early in BackgroundParentImpl::AllocPRemoteWorkerControllerParent

Categories

(Core :: DOM: Service Workers, defect, P2)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- unaffected
firefox110 --- unaffected
firefox111 + fixed

People

(Reporter: jstutte, Assigned: jstutte)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1811195 added a bail out in BackgroundParentImpl::AllocPRemoteWorkerControllerParent that seems to confuse our promise book-keeping.

Given we explicitly handle the failure case later in the process, we should just remove this again.

Regressed by: 1811195
Assignee: nobody → jstutte
Status: NEW → ASSIGNED
Attachment #9314865 - Attachment description: Bug 1813559 - Do not bail out on shutdown in BackgroundParentImpl::DeallocPRemoteWorkerControllerParent but let BackgroundParentImpl::DeallocPRemoteWorkerControllerParent do the error handling. r?#dom-worker-reviewers → Bug 1813559 - Do not bail out on shutdown in BackgroundParentImpl::DeallocPRemoteWorkerControllerParent but let RemoteWorkerManager::LaunchNewContentProcess do the error handling. r?#dom-worker-reviewers
Attachment #9314865 - Attachment description: Bug 1813559 - Do not bail out on shutdown in BackgroundParentImpl::DeallocPRemoteWorkerControllerParent but let RemoteWorkerManager::LaunchNewContentProcess do the error handling. r?#dom-worker-reviewers → Bug 1813559 - Do not bail out on shutdown in BackgroundParentImpl::AllocPRemoteWorkerControllerParent but let RemoteWorkerManager::LaunchNewContentProcess do the error handling. r?#dom-worker-reviewers
Severity: -- → S3
Priority: -- → P2
Pushed by jstutte@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecb7f9336c27
Do not bail out on shutdown in BackgroundParentImpl::AllocPRemoteWorkerControllerParent but let RemoteWorkerManager::LaunchNewContentProcess do the error handling. r=dom-worker-reviewers,asuth
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: