Closed
Bug 1813590
Opened 3 years ago
Closed 3 years ago
Toggle buttons appear incorrectly in RTL when enabled
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
VERIFIED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox109 | --- | wontfix |
| firefox110 | --- | verified |
| firefox111 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
Details
(Keywords: regression, regressionwindow-wanted)
Attachments
(4 files)
Screenshot
See attached, taken from about:addons.
|
||
Updated•3 years ago
|
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/da48b39c5018
Fix toggle buttons appearance in RTL r=hjones
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
|
||
Updated•3 years ago
|
status-firefox109:
--- → wontfix
status-firefox110:
--- → affected
status-firefox-esr102:
--- → unaffected
|
||
Comment 4•3 years ago
|
||
The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox110towontfix.
For more information, please visit auto_nag documentation.
Flags: needinfo?(itiel_yn8)
Comment on attachment 9314933 [details]
Bug 1813590 - Fix toggle buttons appearance in RTL r?mstriemer
Beta/Release Uplift Approval Request
- User impact if declined: Toggles appear incorrectly for RTL users
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial CSS changed
- String changes made/needed:
- Is Android affected?: No
Flags: needinfo?(itiel_yn8)
Attachment #9314933 -
Flags: approval-mozilla-beta?
|
||
Comment 6•3 years ago
|
||
Comment on attachment 9314933 [details]
Bug 1813590 - Fix toggle buttons appearance in RTL r?mstriemer
Approved for our last 110 beta, thanks.
Attachment #9314933 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 7•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Flags: qe-verify+
|
|
||
Updated•3 years ago
|
QA Whiteboard: [qa-triaged]
|
||
Comment 8•3 years ago
|
||
Verified as Fixed on the latest Nightly (111.0a1/20230201215112) and Beta (110.0b9/20232002190127). Tested on Windows 10 x64 and macOS 11.3.1.
about:addons toggle buttons now appear correctly in RTL. For more details, see the attached screenshots.
|
|
||
Updated•3 years ago
|
Flags: qe-verify+
|
|
||
Comment 9•3 years ago
|
||
|
|
||
Comment 10•3 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•