1813848 - Pay attention to RTCRtpParameters.active for audio

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P3)

Description

[Byron Campen [:bwc]]

We're doing this already for video, but we need to implement audio too.

Comment 1

[Philipp Hancke [:fippo]]

bump. This just caused https://github.com/jitsi/jitsi-meet/issues/16586
Easy to repro on https://webrtc.github.io/samples/src/content/peerconnection/bandwidth/ after making a call:

s = pc1.getSenders()[0];
p = s.getParameters();
p.encodings[0].active = false;
s.setParameters(p);

Comment 2

[Philipp Hancke [:fippo]]

can someone dupe this into https://bugzilla.mozilla.org/show_bug.cgi?id=1834806 or the other way round?

Comment 3

[Philipp Hancke [:fippo]]

Attachment: Bug 1813848: wire up RTCRtpEncodingParameters.active for audio

which will cause not packets to be sent

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/58c402846b98
https://hg.mozilla.org/integration/autoland/rev/e467f39747d3
wire up RTCRtpEncodingParameters.active for audio r=bwc

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e467f39747d3