1813879 - White url bar placeholder seen at bottom while panning with top toolbar.

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

From github: https://github.com/mozilla-mobile/fenix/issues/14821.

Steps to reproduce

• have Fenix use the toolbar at top
• first time access thetimes.co.uk so that the cookies consent dialog is shown
• scroll or zoom in/out on that dialog
• Video

Expected behavior

No visual artifacts.

Actual behavior

White area shown at bottom where the bottom toolbar would be.

Device information

• Fenix version: Happening on Fenix release (GV 80.0.1) and on Fenix Nightly (GV 82)

GV tracking

https://bugzilla.mozilla.org/show_bug.cgi?id=1663444

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

So this bug is supposed to be a bug corresponding to an issue on wikipedia, right? From a comment in the github issue tracker;

Thank you for updating.
If you are referring to the issue reported for thetimes.co.uk it may be that that website's design changed over time and just avoids the buggy functionality.
Testing now I still see the issue reported for wikipedia here - #14821 (comment) and the GeckoView ticket is still open - https://bugzilla.mozilla.org/show_bug.cgi?id=1663634 so unfortunately this is still an issue. But it's nice if there are fewer websites on which it is encountered.

On wikipedia, when a footnote opens the document body's overflow style is changed from scroll to hidden and the footnode itself is a position:fixed element. Since bug 1690296, when the overflow style changes, we notify it to GeckoView to tell the browser show the dynamic toolbar. And if the browser wants to show the toolbar, the browser should setVerticalClipping(0) to tell Gecko to change position:fixed elements.

I am going to attach a fix for GeckoView example. I would say this is an issue in Fenix (or AC).

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1813879 - Invoke setVerticalClipping(0) on `onShowDynamicToolbar`. r?#geckoview-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b3a4229d256
Invoke setVerticalClipping(0) on `onShowDynamicToolbar`. r=geckoview-reviewers,m_kato

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1b3a4229d256