1813986 - Sqlite module should be able to register for vacuum

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect, P3)

Description

[Marco Bonardo [:mak]]

Currently the vacuum manager doesn't play well with async connections, it was written quite some time ago and it's basically only serving Places.
I'd like to modify it to get an asyncConnection, and allow it to also set incremental vacuum mode if requested, as well as vacuum attached databases.
To do that, an asyncVacuum() method can be added to the async connection interface, so the work can be done in a runnable. The vacuum manager will just call into that method.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1813986 - Add an asyncVacuum() method to storage async connections, and let VacuumManager use it. r=asuth

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1813986 - Sqlite module connections should be able to register for vacuum on idle. r=asuth

Depends on D168298

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d90fa56c73e5
Add an asyncVacuum() method to storage async connections, and let VacuumManager use it. r=asuth
https://hg.mozilla.org/integration/autoland/rev/14879c9b6b3c
Sqlite module connections should be able to register for vacuum on idle. r=asuth

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1813986) for causing build bustages in Logging.h

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=d76KfPV9QFaTjMp4hZfS5A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=14879c9b6b3ced67b073ecbfcbe5fc939d02c6c8

Logs:
https://treeherder.mozilla.org/logviewer?job_id=409704725&repo=autoland&lineNumber=2004
https://treeherder.mozilla.org/logviewer?job_id=409705052&repo=autoland&lineNumber=28323
https://treeherder.mozilla.org/logviewer?job_id=409703033&repo=autoland&lineNumber=10254

Backout: https://hg.mozilla.org/integration/autoland/rev/a9967148ab72926539ba6bb2a56dadd584da4a24

Comment 5

[Marco Bonardo [:mak]]

there is also a failure on Android to verify, related to chunked growth.

Comment 6

[Marco Bonardo [:mak]]

Ah, of course, on Android we disabled chunked growth https://searchfox.org/mozilla-central/rev/dd2fe65d792943365a03fa996cdf9766829575b6/storage/mozStorageConnection.cpp#2271-2273 so that test should be skipped.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49de76d5683d
Add an asyncVacuum() method to storage async connections, and let VacuumManager use it. r=asuth
https://hg.mozilla.org/integration/autoland/rev/40936d4c96bf
Sqlite module connections should be able to register for vacuum on idle. r=asuth

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/49de76d5683d
https://hg.mozilla.org/mozilla-central/rev/40936d4c96bf