typeaheadfind should not use the deprecated nsIPref

VERIFIED FIXED in mozilla1.3alpha

Status

()

VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: caillon, Assigned: caillon)

Tracking

Trunk
mozilla1.3alpha
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsIPref is deprecated.  You need to use nsIPrefBranchInternal for observers, but
this is made easy by you already implementing nsIObserver.
Attachment #107126 - Flags: review?(aaronl)

Comment 2

16 years ago
Comment on attachment 107126 [details] [diff] [review]
Patch

Some of the AddObserver() calls should really be RemoveObserver(). (The ones
that used to be UnregisterCallback).

Fix those, and r=aaronl
Attachment #107126 - Flags: review?(aaronl) → review+
Comment on attachment 107126 [details] [diff] [review]
Patch

Whoops, fixed those AddObserver()s locally.  Bryner, wanna sr?
Attachment #107126 - Flags: superreview?(bryner)
Attachment #107126 - Flags: superreview?(bryner) → superreview+
Checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.3alpha
rs vrfy
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.