Closed
Bug 181415
Opened 22 years ago
Closed 22 years ago
typeaheadfind should not use the deprecated nsIPref
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.3alpha
People
(Reporter: caillon, Assigned: caillon)
References
Details
Attachments
(1 file)
|
8.12 KB,
patch
|
aaronlev
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
nsIPref is deprecated. You need to use nsIPrefBranchInternal for observers, but
this is made easy by you already implementing nsIObserver.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #107126 -
Flags: review?(aaronl)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 107126 [details] [diff] [review]
Patch
Some of the AddObserver() calls should really be RemoveObserver(). (The ones
that used to be UnregisterCallback).
Fix those, and r=aaronl
Attachment #107126 -
Flags: review?(aaronl) → review+
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 107126 [details] [diff] [review]
Patch
Whoops, fixed those AddObserver()s locally. Bryner, wanna sr?
Attachment #107126 -
Flags: superreview?(bryner)
|
||
Updated•22 years ago
|
Attachment #107126 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.3alpha
|
||
Updated•6 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•