Open Bug 1814168 Opened 1 year ago Updated 3 months ago

Report on the download status and progress in about:translations

Categories

(Firefox :: Translations, enhancement, P3)

Product:
Firefox
Component:
Translations
Type:
enhancement

Tracking

()

People

(Reporter: gregtatum, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(15 obsolete files)

The wasm and language models are downloaded from Remote Settings. Right now things are just dimmed out when we don't have the data, but we should communicate to the user when this isn't available yet.

The addon has a bunch of verbose messages that report the state to the user, and displays the download percentages. I don't believe that Remote Settings surfaces the download percentages at this time, so they may need to be added if we want to surface this to the UI.

See Also: → 1816771

I was about to file this. I thought about:translations didn't work at all (on Linux, too fwiw)

No longer blocks: fx-translation
Mentor: gtatum, enordin
Priority: P2 → P3

The un-privileged UI code for this lives in toolkit/components/translations/content/translations.mjs

The remote settings code is privileged code, and needs to be wired in using the AboutTranslationsChild actor. This is done with a global function similar to this. Or maybe it would be fine to just have a spinner awaiting the promise to download the model and the engine. This is what we do in the URL bar.

about:translations is currently in our backlog and is a developer-focused tool for now for testing the translations engine.

Keywords: good-first-bug

please can i get more details on this bug

Please, could this task be assigned to me ?

Feel free to work on any good first bug that is currently open and unassigned. Bugs are assigned once there is a patch ready and attached to the bug.

Can you give me more informations about this bug

(In reply to Thierry from comment #7)

Can you give me more information about this bug

(In reply to Greg Tatum [:gregtatum] from comment #3)

The un-privileged UI code for this lives in toolkit/components/translations/content/translations.mjs

The remote settings code is privileged code, and needs to be wired in using the AboutTranslationsChild actor. This is done with a global function similar to this. Or maybe it would be fine to just have a spinner awaiting the promise to download the model and the engine. This is what we do in the URL bar.

about:translations is currently in our backlog and is a developer-focused tool for now for testing the translations engine.

@gregtatum @nordzilla do you mean it's just fine for a spinner to be input just before creating the translation engine?
what I realized going through the code is that there are different instances of creating the translation engine.
it looks to me like the translation engine is being destroyed and recreated after a change in language selection,
OR is the spinner to be before the entire page even loads. cause you said something about a dimming feature.
I realized when i used the "about:translations", no dimming feature was apparent to me.
id appreciate if you could shed light on this so i could know if im on the right path
Thank you
abd007
(outreachy)

(In reply to Greg Tatum [:gregtatum] from comment #3)

The un-privileged UI code for this lives in toolkit/components/translations/content/translations.mjs

The remote settings code is privileged code, and needs to be wired in using the AboutTranslationsChild actor. This is done with a global function similar to this. Or maybe it would be fine to just have a spinner awaiting the promise to download the model and the engine. This is what we do in the URL bar.

about:translations is currently in our backlog and is a developer-focused tool for now for testing the translations engine.

Please what are you referring to when you say the model ? is it the translationRequest ?

Flags: needinfo?(gtatum)
Assignee: nobody → peterodejobi9
Status: NEW → ASSIGNED

Hi peterodejobi9

It looks like you've got 3 patches submitted for the exact same behavior.

Could you please take the time to consolidate everything locally into a single patch and then abandon the other two?

To abandon a patch, go to the patch in Phabricator, scroll all the way to the bottom and choose "Add Action..." and abandon the revision.

It looks like they are also linked together as parent/child revisions. It would be good to unlink them from each other and only keep the one patch that you intend to have reviewed.

To unlink them, go to the top of the page in Phabricator, on the right side, and use the "Edit Related Revisions" option.

Flags: needinfo?(peterodejobi9)

(In reply to Erik Nordin [:nordzilla] from comment #14)

Hi peterodejobi9

It looks like you've got 3 patches submitted for the exact same behavior.

Could you please take the time to consolidate everything locally into a single patch and then abandon the other two?

To abandon a patch, go to the patch in Phabricator, scroll all the way to the bottom and choose "Add Action..." and abandon the revision.

It looks like they are also linked together as parent/child revisions. It would be good to unlink them from each other and only keep the one patch that you intend to have reviewed.

To unlink them, go to the top of the page in Phabricator, on the right side, and use the "Edit Related Revisions" option.

Hi Erick one of the related patches is for the linting error phab-bot complained about.

Flags: needinfo?(peterodejobi9)
Attachment #9358521 - Attachment is obsolete: true

(In reply to Erik Nordin [:nordzilla] from comment #14)

Hi peterodejobi9

It looks like you've got 3 patches submitted for the exact same behavior.

Could you please take the time to consolidate everything locally into a single patch and then abandon the other two?

To abandon a patch, go to the patch in Phabricator, scroll all the way to the bottom and choose "Add Action..." and abandon the revision.

It looks like they are also linked together as parent/child revisions. It would be good to unlink them from each other and only keep the one patch that you intend to have reviewed.

To unlink them, go to the top of the page in Phabricator, on the right side, and use the "Edit Related Revisions" option.

Thank you Eric I'll get to work on everything you said right now.

Flags: needinfo?(gtatum) → needinfo?(enordin)
Attachment #9358520 - Attachment is obsolete: true
Attachment #9358509 - Attachment is obsolete: true

is rebuilts i.e language pairs change. r=gregtatum,nordzilla!

when the worker is rebuilt i.e when language pairs change.r=gregtatum,nordzilla!

Depends on D191143

Attachment #9359007 - Attachment is obsolete: true
Attachment #9359007 - Attachment is obsolete: false
Attachment #9359007 - Attachment is obsolete: true
Attachment #9359007 - Attachment is obsolete: false
Attachment #9359007 - Attachment is obsolete: true
Attachment #9359012 - Attachment is obsolete: true
Attachment #9359007 - Attachment is obsolete: false
Attachment #9358509 - Attachment is obsolete: false
Attachment #9358520 - Attachment is obsolete: false
Attachment #9358521 - Attachment is obsolete: false
Attachment #9358521 - Attachment is obsolete: true
Attachment #9358520 - Attachment is obsolete: true
Attachment #9358509 - Attachment is obsolete: true
Attachment #9358787 - Attachment is obsolete: true
Attachment #9359007 - Attachment is obsolete: true
Attachment #9359057 - Attachment is obsolete: true
Attachment #9359007 - Attachment is obsolete: false
Attachment #9358787 - Attachment is obsolete: false
Attachment #9359007 - Attachment is obsolete: true
Attachment #9359077 - Attachment is obsolete: true
Attachment #9358787 - Attachment is obsolete: true
Attachment #9359077 - Attachment is obsolete: false
Attachment #9359077 - Attachment is obsolete: true
Attachment #9358787 - Attachment is obsolete: false
Attachment #9358787 - Attachment is obsolete: true
Attachment #9359057 - Attachment is obsolete: false
Attachment #9358787 - Attachment is obsolete: false
Attachment #9359007 - Attachment is obsolete: false
Attachment #9358520 - Attachment is obsolete: false
Attachment #9358509 - Attachment is obsolete: false
Attachment #9359012 - Attachment is obsolete: false
Attachment #9359077 - Attachment is obsolete: false
Attachment #9359011 - Attachment is obsolete: true
Attachment #9359057 - Attachment is obsolete: true
Attachment #9359007 - Attachment is obsolete: true
Attachment #9359077 - Attachment is obsolete: true
Attachment #9359158 - Attachment is obsolete: true
Attachment #9359156 - Attachment is obsolete: true
Attachment #9359151 - Attachment is obsolete: true
Attachment #9358787 - Attachment is obsolete: true
Attachment #9358520 - Attachment is obsolete: true
Attachment #9358509 - Attachment is obsolete: true
Attachment #9359154 - Attachment is obsolete: true
Attachment #9359158 - Attachment is obsolete: false
Attachment #9359012 - Attachment is obsolete: true

Hey rinwaoluwa, could you please not create so many attachments and mark them as obsolete? I'm not sure what you're trying to do, but it's not the proper way to update revisions. You can push updates to an existing revision on Phabricator. I'm getting an email for every action you are taking here, and it's starting to be a bit disruptive. In addition CI tasks run against the revisions when you push them up. You should only push up updates when you are ready for additional feedback.

(In reply to Greg Tatum [:gregtatum] from comment #27)

Hey rinwaoluwa, could you please not create so many attachments and mark them as obsolete? I'm not sure what you're trying to do, but it's not the proper way to update revisions. You can push updates to an existing revision on Phabricator. I'm getting an email for every action you are taking here, and it's starting to be a bit disruptive. In addition CI tasks run against the revisions when you push them up. You should only push up updates when you are ready for additional feedback.

Hi Erick i'm so sorry about that i just pushed the finished and tested code and abandoned the rest of the revision i was trying to make all the changes into 1 patch like you requested the last time and i have finalized that. I'm sorry once again it's my first time working with mecurial i was having a hard time with it.

Flags: needinfo?(enordin)
Attachment #9359158 - Attachment is obsolete: true
Attachment #9359670 - Attachment is obsolete: true
Attachment #9360323 - Attachment description: Bug 1814168 - [Browser UI] Implemented Loading Spinner for Download Progress and worker rebuild i.e when language pair change.r=nordzilla! → Bug 1814168 - Added head.js file.r=nordzilla!
Attachment #9360323 - Attachment description: Bug 1814168 - Added head.js file.r=nordzilla! → WIP: Bug 1814168 - [Browser UI] Implemented Loading Spinner for Download
Attachment #9360323 - Attachment description: WIP: Bug 1814168 - [Browser UI] Implemented Loading Spinner for Download → Bug 1814168 - [Browser UI] Implemented Loading Spinner for Download Progress and worker rebuild i.e when language pair change,also added a test file.r=nordzilla!
Attachment #9360323 - Attachment description: Bug 1814168 - [Browser UI] Implemented Loading Spinner for Download Progress and worker rebuild i.e when language pair change,also added a test file.r=nordzilla! → Bug 1814168 - [Browser UI] Implemented Loading Spinner for Download Progress and worker rebuild i.e when language pair change,also added a test file. r=nordzilla!
Attachment #9360323 - Attachment is obsolete: true

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Assignee: peterodejobi9 → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: