1814198 - Add a generalized `FenixSnackbar` composable

Status: RESOLVED FIXED

(Firefox for Android :: Design System and Theming, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

From github: https://github.com/mozilla-mobile/fenix/issues/23221.

As of Compose 1.0.5, the platform version of a Snackbar is missing parameters that we require in order to easily match the design spec for our snackbars.

Add a general version that use our designs but still expose customizable messages and actions.

See also the XML layout for our snackbar to match previous design.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Noah Bond [:007]]

Nick and I are taking over this bug

Comment 2

[Noah Bond [:007]]

Adding the updated figma

Comment 3

[Noah Bond [:007]]

Attachment: Bug 1814198 - Part 1 - Create top-level Snackbar component

Comment 4

[Noah Bond [:007]]

Attachment: Bug 1814198 - Part 2 - Remove FenixSnackbar and refactor to use new Snackbar

Comment 5

[Noah Bond [:007]]

Attachment: Bug 1814198 - Part 3 - Update existing usages of `SnackbarHost` to use new Composable

Comment 6

[Noah Bond [:007]]

Per a comment from Anna Yeddi on Slack, we should consider requesting an a11y engineering review for this component when it lands

Comment 7

[Noah Bond [:007]]

Attachment: Bug 1814198 - Part 4 - Fix Snackbar UI tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8af4aa1af53f
Part 1 - Create top-level Snackbar component r=android-reviewers,rsainani

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbb5a6c12011
Part 2 - Remove FenixSnackbar and refactor to use new Snackbar r=android-reviewers,rsainani

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ac551b935f3
Part 3 - Update existing usages of `SnackbarHost` to use new Composable r=android-reviewers,boek

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4d08cdbf975
Part 4 - Fix Snackbar UI tests r=android-reviewers,calu

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8af4aa1af53f
https://hg.mozilla.org/mozilla-central/rev/bbb5a6c12011
https://hg.mozilla.org/mozilla-central/rev/2ac551b935f3
https://hg.mozilla.org/mozilla-central/rev/f4d08cdbf975

Comment 13

[Noah Bond [:007]]

QE, could you please verify that there have been no regressions with the Snackbars in Fenix? This ticket is just a refactor to use a new visual component in the code, so there should be no design regressions nor functionality changes. The one exception is Snackbars on tablets/larger devices now have larger width (and this will be further adjusted in some follow-up work after some UX review).

The following is not necessarily a comprehensive list of all of the ones changed, but they are all of the ones I could track down that are affected:

• Tabs Tray
  • Make bookmark
  • Save tab to collection
  • Close tab + undo
• Bookmarks
  • Adding/Deleting from menu redesign
  • Adding/deleting from legacy menu
  • Invalid bookmark URL
• URL copied (via bookmarks screen)
• PDF print warning
• Adding/Removing shortcut/top site
• Deleting browser data
• User account authenticated
• Shared tabs success/fail
• Copy link to clipboard
• Failed to query extensions
• Add-ons popup download canceled
• Toolbar
  • Long clicking on the toolbar URL (non-edit), hit copy on Android < S & Android > 12
• Web content long press snackbars - (copy link, etc.)
• Downloads
  • Cannot open file error
• Sync
  • Account sync is on
• Collections
  • Adding a tab via the browser menu
  • Adding a tab via the Tabs tray
  • Collection created
  • Tab added to collection
  • Tab removed from collection
  • Collection renamed
• Wallpaper error
  • Nimbus experiment manual enrolling from secret settings
• Snackbar message for enrolling in a Nimbus experiment from the secret settings when Studies preference is Off.
• Account settings error - empty device name
• Delete browsing data
• Logins - Android < 12 - copied username/password
• Create custom search engine
• Wallpaper settings
  • Update wallpaper Success
  • Wallpaper download failed

Comment 14

[Lorand Janos]

Verified as fixed on the latest Nightly build (134.0a1 from 2024-11-11).

Apart from a recently discovered but not new detail here, I didn't discover any unknown issues.

Device used: Google Pixel 9 Pro XL (Android 14).

Marking the ticket as verified on 134.