Closed Bug 1814375 Opened 2 years ago Closed 7 months ago

Update libsrtp to new version v2.5.0 from 2023-02-01 08:25:02

Categories

(Core :: WebRTC: Networking, enhancement)

Product:
Core
Component:
WebRTC: Networking
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1881905
Tracking Flags:
Tracking Status
firefox111 --- wontfix
firefox112 --- wontfix
firefox113 --- wontfix
firefox114 --- wontfix
firefox115 --- wontfix
firefox116 --- wontfix
firefox117 --- fix-optional
firefox118 --- affected
firefox119 --- affected
firefox120 --- affected
firefox121 --- affected
firefox122 --- affected
firefox123 --- affected
firefox124 --- affected
firefox125 --- affected

People

(Reporter: update-bot, Assigned: jesup, NeedInfo)

References

Details

(Whiteboard: [3pl-filed][task_id: d4utXMbwTFu8wUWVHDgEqw])

Attachments

(1 file, 1 obsolete file)

Bug 1814375: Update libsrtp to v2.5.0 from 2023-02-01 08:25:02 r?jesup
48 bytes, text/x-phabricator-request
Details | Review

This update covers 109 commits:

a566a9cfcd619e8327784aa7cff4a1276dc1e895 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/a566a9cfcd619e8327784aa7cff4a1276dc1e895
Authored: 2023-02-01 08:25:02 +0100
Committed: 2023-02-01 08:25:02 +0100

create 2.5.0 release

Files Modified:

  • configure
  • configure.ac

b3891a97e5415fabaf22318da6dbb0153e25462c by Pascal Bühler

https://github.com/cisco/libsrtp/commit/b3891a97e5415fabaf22318da6dbb0153e25462c
Authored: 2023-01-31 14:04:48 +0100
Committed: 2023-01-31 14:04:48 +0100

update change log

preparing for 2.5.0 release

Files Modified:

  • CHANGES

bc16c317f1969e003de26ddc2152ce47cc35e605 by Oliver Shenton

https://github.com/cisco/libsrtp/commit/bc16c317f1969e003de26ddc2152ce47cc35e605
Authored: 2023-01-23 13:43:49 +0000
Committed: 2023-01-24 12:21:30 +0000

Make mbedtls hmac less restrictive in line with RFC and library capabilities.

Files Modified:

  • crypto/hash/hmac_mbedtls.c

68ef5c5f78373be161b008e9b7fb4f98b5941c39 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/68ef5c5f78373be161b008e9b7fb4f98b5941c39
Authored: 2023-01-23 22:22:11 +0100
Committed: 2023-01-23 22:22:11 +0100

schedule cmake CI once a week

A few times now CI builds have broken due to changes in the CI environment, but these are not picked up before the next PR / commit. This will try to detect CI breakage early so it can be fix independently of any other code change.

Files Modified:

  • .github/workflows/cmake.yml

a3150271bbb66fd284498ca0f061a81398764fea by Pascal Bühler

https://github.com/cisco/libsrtp/commit/a3150271bbb66fd284498ca0f061a81398764fea
Authored: 2023-01-23 21:47:26 +0100
Committed: 2023-01-23 21:47:26 +0100

format

Files Modified:

  • test/cutest.h
  • test/srtp_driver.c

70b28c69a2d8250c2c444f18b52f9f41844d2232 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/70b28c69a2d8250c2c444f18b52f9f41844d2232
Authored: 2023-01-23 21:45:05 +0100
Committed: 2023-01-23 21:45:05 +0100

use snprintf instead sprintf

sprintf is marked as deprecated in OSX 13.1

Files Modified:

  • test/cutest.h
  • test/srtp_driver.c

fec3449a3ebe22cc7b51694b9563965592e459c7 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/fec3449a3ebe22cc7b51694b9563965592e459c7
Authored: 2023-01-19 10:13:41 +0100
Committed: 2023-01-23 18:15:03 +0100

do not use system include for srtp_priv.h

Including srtp_priv.h should only be done form inside source tree.

Files Modified:

  • include/stream_list_priv.h

d1eb03abfe712f223e9cb3ded1c1392e827aa981 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/d1eb03abfe712f223e9cb3ded1c1392e827aa981
Authored: 2023-01-12 19:16:00 +0100
Committed: 2023-01-12 19:16:00 +0100

address comments from review, no function change

Files Modified:

  • include/srtp_priv.h
  • include/stream_list_priv.h
  • srtp/srtp.c
  • test/srtp_driver.c

07334b277cb2cc9ca30f087f022f57e9f208e3a7 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/07334b277cb2cc9ca30f087f022f57e9f208e3a7
Authored: 2023-01-12 18:20:11 +0100
Committed: 2023-01-12 18:20:11 +0100

move stream list replace test to own CI work flow

Files Added:

  • .github/workflows/stream_list.yml

Files Modified:

  • .github/workflows/cmake.yml

8ef408485cee69e28a9e758f01696290dd94d059 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/8ef408485cee69e28a9e758f01696290dd94d059
Authored: 2023-01-10 12:17:14 +0100
Committed: 2023-01-10 12:47:28 +0100

use cmake to build and run test

This does it in a cross platform manor.

Files Modified:

  • .github/workflows/cmake.yml

914cb552fbcc1854f5c88a969eaa34d22377e598 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/914cb552fbcc1854f5c88a969eaa34d22377e598
Authored: 2022-12-23 13:55:24 +0100
Committed: 2023-01-08 20:45:14 +0100

alternative stream list api and unit tests for the api

Beside some small API rename the main difference is that the
list implementation is not responsible for deallocating streams.
Calling srtp_stream_list_dealloc() on a list that is not empty
results in an error.

This also changes the default implementation to be a double linked
list making removing items faster.

Files Modified:

  • .github/workflows/cmake.yml
  • include/srtp_priv.h
  • include/stream_list_priv.h
  • srtp/srtp.c
  • test/srtp_driver.c

07ca6ad289f7d5384f39265e1d5118881e1a375d by Pascal Bühler

https://github.com/cisco/libsrtp/commit/07ca6ad289f7d5384f39265e1d5118881e1a375d
Authored: 2023-01-06 18:15:12 +0100
Committed: 2023-01-06 18:15:12 +0100

use ubuntu 20.04 when running with valgrind

ubunutu 22.04 currently uses glibc 2.35 that has a memory leak that is triggered by nss.
see: https://sourceware.org/bugzilla/show_bug.cgi?id=29062
This is fixed in glibc 2.36, so until that is available use ubunutu 20.04

Files Modified:

  • .github/workflows/autotools.yml

cba4c0c13621cc9553b4e512eced22f3a943d1d6 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/cba4c0c13621cc9553b4e512eced22f3a943d1d6
Authored: 2022-12-16 11:25:14 +0100
Committed: 2022-12-16 11:25:14 +0100

add checking for EVP_CIPHER_CTX_reset in configure

This is a new symbol that is needed and part of the
reason for updating the minimal version.

Files Modified:

  • configure
  • configure.ac

a0f8490dd0d221332d5b4fa330d16c18280e8a72 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/a0f8490dd0d221332d5b4fa330d16c18280e8a72
Authored: 2022-12-16 11:13:53 +0100
Committed: 2022-12-16 11:13:53 +0100

remove more code checking openssl versions < 1.1.0

Files Modified:

  • crypto/cipher/aes_gcm_ossl.c
  • crypto/cipher/aes_icm_ossl.c

0fc6310a262b4741261c70a7a5ffd75ba2827495 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/0fc6310a262b4741261c70a7a5ffd75ba2827495
Authored: 2022-12-16 10:25:47 +0100
Committed: 2022-12-16 10:25:47 +0100

move to ubuntu-latest for workflows

ubuntu-22.04 should now be supported

Files Modified:

  • .github/workflows/android.yml
  • .github/workflows/autotools.yml
  • .github/workflows/cmake.yml
  • .github/workflows/coverity_scan.yml
  • .github/workflows/format_check.yml
  • .github/workflows/fuzzer_build.yml

77382a0d17d0007718bcfa2dd845e92721301506 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/77382a0d17d0007718bcfa2dd845e92721301506
Authored: 2022-12-16 10:13:16 +0100
Committed: 2022-12-16 10:13:16 +0100

remove unnecessary checks for null

These api's are no op for null so no need.
As mentioned by @bifurcation.

Files Modified:

  • crypto/hash/hmac_ossl.c

523c2a9cddc87b35053d6bce268308af6bc9174c by Pascal Bühler

https://github.com/cisco/libsrtp/commit/523c2a9cddc87b35053d6bce268308af6bc9174c
Authored: 2022-12-15 05:32:38 +0100
Committed: 2022-12-15 05:32:38 +0100

fix compile after merge

Files Modified:

  • srtp/srtp.c

5bceeabc46b83e4bcad580b9ad4f25e879a22848 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/5bceeabc46b83e4bcad580b9ad4f25e879a22848
Authored: 2022-12-15 04:48:02 +0100
Committed: 2022-12-15 04:48:14 +0100

update min openssl version to 1.1.0

As of commit #593 the minimal supported version is 1.1.0,
this updates build files to check for that version.
This also means the check for a broken openssl cleans function is
obsolete so it is removed.

#597

Files Modified:

  • CMakeLists.txt
  • config_in.h
  • configure
  • configure.ac
  • crypto/math/datatypes.c
  • meson.build

3d640bfa7de18d4b2f558f0ed6f94175c594d871 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/3d640bfa7de18d4b2f558f0ed6f94175c594d871
Authored: 2022-12-15 03:49:33 +0100
Committed: 2022-12-15 03:49:33 +0100

Add android build to CI

A single simple build, just to ensure it works and
demonstrate how it can be done.

Files Added:

  • .github/workflows/android.yml

c83812034ba97b8ec9555d2b3ee8a0d6fa75dfd3 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/c83812034ba97b8ec9555d2b3ee8a0d6fa75dfd3
Authored: 2022-12-15 02:32:19 +0100
Committed: 2022-12-15 02:32:19 +0100

flip the logic as to which ctx is dup'd

As suggested by @bifurcation, it is nicer to have the dup
logic in the init phase and have the hash code consistent.

Files Modified:

  • crypto/hash/hmac_ossl.c

131c0bba29d5a3b5d7590c173782a101fff139b3 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/131c0bba29d5a3b5d7590c173782a101fff139b3
Authored: 2022-12-14 00:59:49 +0100
Committed: 2022-12-14 00:59:49 +0100

only run against the main branch

this is just keeping consistent with the other work flows

Files Modified:

  • .github/workflows/cifuzz.yml

5d9c5fd8d24f58e222645ceca728a49cc957bfc6 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/5d9c5fd8d24f58e222645ceca728a49cc957bfc6
Authored: 2022-12-14 00:10:12 +0100
Committed: 2022-12-14 00:10:12 +0100

Add comment about the 3 flavours of OpenSSL HMAC

Files Modified:

  • crypto/hash/hmac_ossl.c

1ccdd7612fe11154be14ac08caf04f1412efdb4a by Pascal Bühler

https://github.com/cisco/libsrtp/commit/1ccdd7612fe11154be14ac08caf04f1412efdb4a
Authored: 2022-12-13 23:20:27 +0100
Committed: 2022-12-13 23:46:00 +0100

memset not required when using srtp_crypto_alloc

srtp_crypto_alloc uses calloc

Files Modified:

  • crypto/hash/hmac_ossl.c

d332304b2f9d4fcf41337d06ff63d914ea6935a8 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/d332304b2f9d4fcf41337d06ff63d914ea6935a8
Authored: 2022-12-13 23:44:02 +0100
Committed: 2022-12-13 23:44:02 +0100

Apply suggestions from code review

Co-authored-by: Richard Barnes <rlb@ipv.sx>

Files Modified:

  • crypto/hash/hmac_ossl.c

38ccf12c3472c58ff1363a0b75aeb54242bef1ee by Pascal Bühler

https://github.com/cisco/libsrtp/commit/38ccf12c3472c58ff1363a0b75aeb54242bef1ee
Authored: 2022-12-12 04:52:47 +0100
Committed: 2022-12-12 04:52:47 +0100

prevent "declaration without a prototype" warnings

Full warning:
"a function declaration without a prototype is deprecated in all versions of C"

Files Modified:

  • test/replay_driver.c
  • test/srtp_driver.c
  • test/test_srtp.c

e9618775d57dee40fbc89e3ced6769d8a9af16c0 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/e9618775d57dee40fbc89e3ced6769d8a9af16c0
Authored: 2022-12-12 04:48:21 +0100
Committed: 2022-12-12 04:48:21 +0100

prevent "set but not used warning"

Failures where counted but never used, so just remove.

Files Modified:

  • test/replay_driver.c

97d1c2121d1208456b2b10555d7a19361c086fb9 by Lars Gullik Bjønnes

https://github.com/cisco/libsrtp/commit/97d1c2121d1208456b2b10555d7a19361c086fb9
Authored: 2022-11-28 21:52:52 +0100
Committed: 2022-12-12 04:40:10 +0100

Make definitions prototypes

Files Modified:

  • crypto/kernel/crypto_kernel.c
  • crypto/kernel/err.c
  • srtp/srtp.c

7041beb12e8a27aa9fa8b8f78684c4dbd416531e by Pascal Bühler

https://github.com/cisco/libsrtp/commit/7041beb12e8a27aa9fa8b8f78684c4dbd416531e
Authored: 2022-12-12 03:03:54 +0100
Committed: 2022-12-12 03:03:54 +0100

update to clang-format-12

For CI this will work on both Ubuntu 20.04 & 22.04 .
This will allow CI to move to ubuntu-latest, see #622

Files Modified:

  • .github/workflows/format_check.yml
  • format.sh
  • test/rtp.c

46fb1a2c2dc91e1410d3e9043fd088158bed4c92 by Pascal Buhler

https://github.com/cisco/libsrtp/commit/46fb1a2c2dc91e1410d3e9043fd088158bed4c92
Authored: 2022-12-12 01:22:47 +0100
Committed: 2022-12-12 01:25:43 +0100

Include some information about supported ciphers

Provide a little info on the consequence of configuring different crypto backends, as request in #620 .

Files Modified:

  • README.md

7a1416d8bb12f15370512835a9949daf9783848e by Pascal Buhler

https://github.com/cisco/libsrtp/commit/7a1416d8bb12f15370512835a9949daf9783848e
Authored: 2022-12-12 01:09:23 +0100
Committed: 2022-12-12 01:09:23 +0100

Show configured warning when running cmake

Files Modified:

  • CMakeLists.txt

d010371dfb201ca6c2ec27c185926df46491d465 by Pascal Buhler

https://github.com/cisco/libsrtp/commit/d010371dfb201ca6c2ec27c185926df46491d465
Authored: 2022-05-04 17:29:52 +0200
Committed: 2022-12-12 00:12:07 +0100

use EVP_MAC_CTX_dup for OpenSSL3 versions less than 3.0.3

The new EVP_MAC_CTX api in OpenSSL3 did not initially support
calling EVP_MAC_init to reintialize a CTX like the old HMAC_Init_ex
could be used.
A work around is to duplicate the CTX but this comes at a
perfromance cost. Use runtime version check to use EVP_MAC_CTX_dup
if version is less than 3.0.3 otherwise use EVP_MAC_init.

Files Modified:

  • crypto/hash/hmac_ossl.c

63b8f4412bb17e3ead6862da755b4d118c252596 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/63b8f4412bb17e3ead6862da755b4d118c252596
Authored: 2022-05-02 10:20:19 +0200
Committed: 2022-12-11 23:40:22 +0100

Use OpenSSl EVP MAC api if it is available

With OpenSSL 3 the HAMC CTX api has been deprecated and
EVP MAC should be used instead. This change adds a compile
time check on OpeenSSL version and will use the new api if the
version is greater than or equal to 3 .

Files Modified:

  • crypto/hash/hmac_ossl.c

059bce7b1b9f2fab6311a5bd081bc9d801cd8e2a by Pascal Bühler

https://github.com/cisco/libsrtp/commit/059bce7b1b9f2fab6311a5bd081bc9d801cd8e2a
Authored: 2022-05-02 09:46:14 +0200
Committed: 2022-12-11 23:30:26 +0100

Add OpenSSL3 build to cmake CI

For now this is only for macos as it is simple to add and
covers the usecase required.

Files Modified:

  • .github/workflows/cmake.yml

cb9677366995ab437663cacc172a5c73c07dc729 by Pascal Buhler

https://github.com/cisco/libsrtp/commit/cb9677366995ab437663cacc172a5c73c07dc729
Authored: 2022-12-07 23:00:33 +0100
Committed: 2022-12-07 23:50:28 +0100

Add policy_set_aes_cm_192_xxx symbols to def file

This is just for completness, see #615

Files Modified:

  • srtp.def

5c09a690a52c5cf08fa7d5514c9587c2cd7dfdd1 by Pascal Buhler

https://github.com/cisco/libsrtp/commit/5c09a690a52c5cf08fa7d5514c9587c2cd7dfdd1
Authored: 2022-12-07 23:32:38 +0100
Committed: 2022-12-07 23:40:38 +0100

switch to use ubuntu-20.04 in workflows

ubuntu-latest in moving to ubuntu-22.04, this wil require
updates fro clang format and openssl3, so in the mean
time use ubuntu-20.04, #622

Files Modified:

  • .github/workflows/autotools.yml
  • .github/workflows/cmake.yml
  • .github/workflows/coverity_scan.yml
  • .github/workflows/format_check.yml
  • .github/workflows/fuzzer_build.yml

5e03b6403478b4a8c8430d908ae5d0b88ee04784 by Gregor Jasny

https://github.com/cisco/libsrtp/commit/5e03b6403478b4a8c8430d908ae5d0b88ee04784
Authored: 2022-11-25 17:23:47 +0100
Committed: 2022-11-30 09:05:13 +0100

Hide some more symbols

Files Modified:

  • crypto/kernel/crypto_kernel.c
  • crypto/math/datatypes.c
  • srtp/srtp.c

b94649cae911d8cdb8c083187c59246d70eb4b25 by David Korczynski

https://github.com/cisco/libsrtp/commit/b94649cae911d8cdb8c083187c59246d70eb4b25
Authored: 2022-11-24 15:05:40 -0800
Committed: 2022-11-24 15:05:40 -0800

run CIFuzz on push too

Files Modified:

  • .github/workflows/cifuzz.yml

e19efdc1683dcf03710eb0fbc640c5a3359b535f by Richard Barnes

https://github.com/cisco/libsrtp/commit/e19efdc1683dcf03710eb0fbc640c5a3359b535f
Authored: 2022-11-21 10:53:59 -0500
Committed: 2022-11-21 10:53:59 -0500

Use current directions in stream update test

Files Modified:

  • test/srtp_driver.c

998491b1893059b331a34626db46c6ed7c672ac0 by David Korczynski

https://github.com/cisco/libsrtp/commit/998491b1893059b331a34626db46c6ed7c672ac0
Authored: 2022-11-20 16:22:15 -0800
Committed: 2022-11-20 16:22:15 -0800

add CIFuzz Github action to workflows

Files Added:

  • .github/workflows/cifuzz.yml

e1cb78ce03cb55b32ef26d844f94e53ec9f95060 by Richard Barnes

https://github.com/cisco/libsrtp/commit/e1cb78ce03cb55b32ef26d844f94e53ec9f95060
Authored: 2022-11-07 14:28:46 -0500
Committed: 2022-11-07 14:28:46 -0500

clang-format

Files Modified:

  • crypto/cipher/cipher.c

9b26f8adf0d1fcf57a9af202a62e4478bddca896 by Richard Barnes

https://github.com/cisco/libsrtp/commit/9b26f8adf0d1fcf57a9af202a62e4478bddca896
Authored: 2022-11-07 14:22:54 -0500
Committed: 2022-11-07 14:22:54 -0500

Use more accurate lengths

Files Modified:

  • crypto/cipher/cipher.c

c038fac38e4c19d363b39062579cfd5824ae9f5b by Richard Barnes

https://github.com/cisco/libsrtp/commit/c038fac38e4c19d363b39062579cfd5824ae9f5b
Authored: 2022-11-07 11:45:38 -0500
Committed: 2022-11-07 11:47:18 -0500

clang-format

Files Modified:

  • crypto/cipher/cipher.c

1f9cf2c68bc0e94f75a02ebb55ff5cd8d7522476 by Richard Barnes

https://github.com/cisco/libsrtp/commit/1f9cf2c68bc0e94f75a02ebb55ff5cd8d7522476
Authored: 2022-11-06 21:57:30 -0500
Committed: 2022-11-06 21:57:30 -0500

Also set AAD

Files Modified:

  • crypto/cipher/cipher.c

4b78d08a3fb710e4437107c6961657afed7bcf9a by Richard Barnes

https://github.com/cisco/libsrtp/commit/4b78d08a3fb710e4437107c6961657afed7bcf9a
Authored: 2022-11-06 21:50:17 -0500
Committed: 2022-11-06 21:50:17 -0500

Call get_tag in cipher performance test when possible

Files Modified:

  • crypto/cipher/cipher.c

0bc8b9bdaf52b92db9d409094c3375ea092a25d5 by Alba Mendez

https://github.com/cisco/libsrtp/commit/0bc8b9bdaf52b92db9d409094c3375ea092a25d5
Authored: 2022-09-12 20:33:38 +0200
Committed: 2022-09-12 20:33:38 +0200

(format)

Files Modified:

  • srtp/srtp.c

55f409f6129196e0f22c2b28fabce130712b9b09 by Alba Mendez

https://github.com/cisco/libsrtp/commit/55f409f6129196e0f22c2b28fabce130712b9b09
Authored: 2022-09-12 13:31:37 +0200
Committed: 2022-09-12 20:32:59 +0200

allow insertions to fail

Files Modified:

  • include/stream_list_priv.h
  • srtp/srtp.c

6b0aa2dadbc41dd1f34e20324b7d86e6aff57faa by Alba Mendez

https://github.com/cisco/libsrtp/commit/6b0aa2dadbc41dd1f34e20324b7d86e6aff57faa
Authored: 2022-09-07 02:42:46 +0200
Committed: 2022-09-07 02:42:46 +0200

update tests

removes code duplication as well

Files Modified:

  • test/srtp_driver.c

f161ac16c28c9552729cfe3850cd6886b57f96d5 by Alba Mendez

https://github.com/cisco/libsrtp/commit/f161ac16c28c9552729cfe3850cd6886b57f96d5
Authored: 2022-09-05 12:57:10 +0200
Committed: 2022-09-06 02:44:17 +0200

expose missing internal method

custom implementations need to have it available

Files Modified:

  • include/srtp_priv.h

6653a8667e9065ddbd5f8f914324121aa22a7488 by Alba Mendez

https://github.com/cisco/libsrtp/commit/6653a8667e9065ddbd5f8f914324121aa22a7488
Authored: 2022-09-06 02:34:07 +0200
Committed: 2022-09-06 02:43:22 +0200

use in get_protect_trailer_length

Files Modified:

  • srtp/srtp.c

feac4cea58d6d88a49c7a07d7690c69f2562b283 by Alba Mendez

https://github.com/cisco/libsrtp/commit/feac4cea58d6d88a49c7a07d7690c69f2562b283
Authored: 2022-09-05 23:35:49 +0200
Committed: 2022-09-06 02:43:22 +0200

use in update_template_streams()

to make it work with the generalized interface,
instead of removing only the matching streams and then
merging both lists, we remove & add every stream.

the old stream is then deallocated and replaced by the
newly produced one

Files Modified:

  • srtp/srtp.c

8e314717511d9e410e0454139ee8334722a25bc8 by Alba Mendez

https://github.com/cisco/libsrtp/commit/8e314717511d9e410e0454139ee8334722a25bc8
Authored: 2022-09-05 23:33:04 +0200
Committed: 2022-09-06 02:43:22 +0200

2/2 use it

Files Modified:

  • include/srtp_priv.h
  • srtp/srtp.c

b8734bb7443ceb63374b44fd01d78fb92572e69a by Alba Mendez

https://github.com/cisco/libsrtp/commit/b8734bb7443ceb63374b44fd01d78fb92572e69a
Authored: 2022-09-06 02:32:29 +0200
Committed: 2022-09-06 02:43:22 +0200

1/2 use it

Files Modified:

  • srtp/srtp.c

6a8eea3c94a83673bcbd621d5d928dfb071c1b61 by Alba Mendez

https://github.com/cisco/libsrtp/commit/6a8eea3c94a83673bcbd621d5d928dfb071c1b61
Authored: 2022-09-05 12:51:17 +0200
Committed: 2022-09-06 02:43:22 +0200

add stream list interface

Files Added:

  • include/stream_list_priv.h

Files Modified:

  • include/srtp_priv.h
  • srtp/srtp.c

50675e20c5d5645b6a517941cd46e3024b6408f5 by Paul E. Jones

https://github.com/cisco/libsrtp/commit/50675e20c5d5645b6a517941cd46e3024b6408f5
Authored: 2022-09-02 02:17:42 -0400
Committed: 2022-09-02 02:17:42 -0400

Create alias for srtp2 as libSRTP::srtp2

Files Modified:

  • CMakeLists.txt

c93b79f16161a52b1d01bb202e4bdb24691f6dc6 by Paul E. Jones

https://github.com/cisco/libsrtp/commit/c93b79f16161a52b1d01bb202e4bdb24691f6dc6
Authored: 2022-05-30 15:07:05 -0400
Committed: 2022-05-30 15:07:05 -0400

Minor edits: unreached line of code, consistency, spelling

Files Modified:

  • crypto/cipher/aes_icm_ossl.c
  • crypto/hash/hmac_ossl.c

adc976fe324a71ad1c81ea15f28da866345bae2c by Pascal Bühler

https://github.com/cisco/libsrtp/commit/adc976fe324a71ad1c81ea15f28da866345bae2c
Authored: 2022-05-04 20:52:41 +0200
Committed: 2022-05-04 20:52:41 +0200

cmake warnings as errors configurable

Default on.

Files Modified:

  • CMakeLists.txt

fa104f4778addb0c3d6dbe06a066816373751818 by Rick Porter

https://github.com/cisco/libsrtp/commit/fa104f4778addb0c3d6dbe06a066816373751818
Authored: 2022-05-04 09:00:42 -0400
Committed: 2022-05-04 09:00:42 -0400

Fix compile error due to unused variable

Without this change, I see the following error:
In file included from test/test_srtp.c:54:
./test/cutest.h:262:16: warning: variable 'n' set but not used [-Wunused-but-set-variable]
size_t n = 0;
^

Files Modified:

  • test/cutest.h

324b4ff3416c16e2055b99dd4c1bff4cc90526a0 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/324b4ff3416c16e2055b99dd4c1bff4cc90526a0
Authored: 2022-05-02 20:03:08 +0200
Committed: 2022-05-02 20:06:43 +0200

set hdr_size as const

Files Modified:

  • test/srtp_driver.c

b19d4e50e46de0f06e0924609e053298e712fa03 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/b19d4e50e46de0f06e0924609e053298e712fa03
Authored: 2022-05-02 10:56:05 +0200
Committed: 2022-05-02 10:56:05 +0200

Fix warnings after enabling in CI

Files Modified:

  • crypto/cipher/aes_gcm_mbedtls.c
  • crypto/cipher/aes_gcm_ossl.c
  • crypto/cipher/aes_icm.c
  • crypto/cipher/aes_icm_mbedtls.c
  • crypto/cipher/aes_icm_nss.c
  • crypto/cipher/aes_icm_ossl.c
  • crypto/cipher/null_cipher.c
  • crypto/hash/hmac_nss.c
  • crypto/hash/hmac_ossl.c
  • crypto/hash/null_auth.c
  • crypto/include/datatypes.h
  • crypto/replay/rdbx.c
  • crypto/test/cipher_driver.c
  • crypto/test/datatypes_driver.c
  • crypto/test/sha1_driver.c
  • srtp/srtp.c
  • test/rdbx_driver.c
  • test/roc_driver.c
  • test/rtp_decoder.c
  • test/rtp_decoder.h
  • test/srtp_driver.c
  • test/test_srtp.c
  • test/ut_sim.c
  • test/util.c

2a12d3b5fff4a90170cd8f82484d39a7e5364fbb by Pascal Bühler

https://github.com/cisco/libsrtp/commit/2a12d3b5fff4a90170cd8f82484d39a7e5364fbb
Authored: 2022-05-02 10:52:08 +0200
Committed: 2022-05-02 10:52:08 +0200

Add more wranings flags to cmake CI build

Enable warnings as errors on windows.

Files Modified:

  • CMakeLists.txt

c8a9fd19f1136965d50f76d5ef39ef506fed1d97 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/c8a9fd19f1136965d50f76d5ef39ef506fed1d97
Authored: 2022-05-02 09:32:00 +0200
Committed: 2022-05-02 09:32:00 +0200

Treat warnings as errors when building with cmake

This will catch OpenSSL deprecated api warnings.
Only enabled for Clang and GNU at this point.

Files Modified:

  • CMakeLists.txt

11366ac018642e06a5c05018937ef34d13b66a0c by Pascal Bühler

https://github.com/cisco/libsrtp/commit/11366ac018642e06a5c05018937ef34d13b66a0c
Authored: 2022-02-22 17:54:29 +0100
Committed: 2022-02-22 17:54:29 +0100

Update coverity_scan.yml

update to new "main" branch name

Files Modified:

  • .github/workflows/coverity_scan.yml

53e2b5b22456e340fb009ee3929550d7e72cd412 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/53e2b5b22456e340fb009ee3929550d7e72cd412
Authored: 2022-02-22 17:53:50 +0100
Committed: 2022-02-22 17:53:50 +0100

Update fuzzer_build.yml

update to new "main" branch name

Files Modified:

  • .github/workflows/fuzzer_build.yml

003202b994f2c54cd8cae94a8a185baf9837d654 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/003202b994f2c54cd8cae94a8a185baf9837d654
Authored: 2022-02-22 17:53:11 +0100
Committed: 2022-02-22 17:53:11 +0100

Update format_check.yml

update to new "main" branch name

Files Modified:

  • .github/workflows/format_check.yml

06707077cdf2ccd3fe3eca6a66c9ff53edce358a by Pascal Bühler

https://github.com/cisco/libsrtp/commit/06707077cdf2ccd3fe3eca6a66c9ff53edce358a
Authored: 2022-02-22 17:52:38 +0100
Committed: 2022-02-22 17:52:38 +0100

Update cmake.yml

update to new "main" branch name

Files Modified:

  • .github/workflows/cmake.yml

d2fbea82d71f2f79ad05630cd145299acfdcb128 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/d2fbea82d71f2f79ad05630cd145299acfdcb128
Authored: 2022-02-22 17:52:08 +0100
Committed: 2022-02-22 17:52:08 +0100

Update autotools.yml

update to new "main" branch name

Files Modified:

  • .github/workflows/autotools.yml

d3e154bd8378f2eefabd8ed808bf77e27e762732 by Klemens Nanni

https://github.com/cisco/libsrtp/commit/d3e154bd8378f2eefabd8ed808bf77e27e762732
Authored: 2022-01-16 00:19:28 +0300
Committed: 2022-02-04 11:55:27 +0300

test: Use pkill(1) not killall(1)

Not all operating systems, e.g. OpenBSD, have killall; pkill(1) however
should be available on all OSes shipping killall(1).

This makes tests pass on OpenBSD without further changes.

Files Modified:

  • test/rtpw_test.sh
  • test/rtpw_test_gcm.sh

94e7d4016a356c41bb920465c81dfcb1e378299e by Pascal Bühler

https://github.com/cisco/libsrtp/commit/94e7d4016a356c41bb920465c81dfcb1e378299e
Authored: 2022-02-04 09:41:55 +0100
Committed: 2022-02-04 09:41:55 +0100

Update test/srtp_driver.c

format code

Files Modified:

  • test/srtp_driver.c

1fe2dbd7e16e0a2fc58cb475b58a4060fc952dd8 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/1fe2dbd7e16e0a2fc58cb475b58a4060fc952dd8
Authored: 2022-01-31 13:57:54 -0500
Committed: 2022-01-31 13:57:54 -0500

Move set-and-rollover test in to set-ROC test

Files Modified:

  • test/srtp_driver.c

2203114ae11178e80b537b6ed6d61da685433527 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/2203114ae11178e80b537b6ed6d61da685433527
Authored: 2022-01-31 13:53:47 -0500
Committed: 2022-01-31 13:53:47 -0500

Skip unnecessary prep in receiver ROC tests

Files Modified:

  • test/srtp_driver.c

15e87094e4f5622cccc307cee9eafad36ff74c13 by Niels De Graef

https://github.com/cisco/libsrtp/commit/15e87094e4f5622cccc307cee9eafad36ff74c13
Authored: 2022-01-24 14:58:50 +0100
Committed: 2022-01-24 15:00:44 +0100

Use inet_pton() when available

inet_aton() and inet_ntoa() are considered deprecated, and can even
show up under certain scanners. Use the replacement inet_pton()
instead.

Files Modified:

  • CMakeLists.txt
  • config_in.h
  • config_in_cmake.h
  • configure
  • configure.ac
  • meson.build
  • test/rtpw.c

16483b18a9980575bee23898b2dbfbe2a4675d84 by Klemens Nanni

https://github.com/cisco/libsrtp/commit/16483b18a9980575bee23898b2dbfbe2a4675d84
Authored: 2022-01-15 23:19:35 +0300
Committed: 2022-01-15 23:44:37 +0300

Remove compatibility code for legacy OpenSSL to fix LibreSSL build

In current LibreSSL, HMAC_CTX aka. struct hmac_ctx_st is an opaque
structure as of LibreSSL hmac.h revision 1.15 (14.01.2022) [0], thus
sizeof(HMAC_CTX) fails to compile.

The non-legacy code path should compile with LibreSSL versions as old
as 2.7.0 (21.03.2018).

Found while building https://github.com/desktop-app/tg_owt which bundles
libsrtp 2.2.0 [1] on OpenBSD 7.0 -CURRENT/with latest LibreSSL.

Suggestion to remove the legacy code from Theo Buehler, thanks.

0: http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libcrypto/hmac/hmac.h?rev=1.15&content-type=text/x-cvsweb-markup
1: https://github.com/desktop-app/tg_owt/blob/6708e0d31a73e64fe12f54829bf4060c41b2658e/src/third_party/libsrtp/crypto/hash/hmac_ossl.c#L85

Files Modified:

  • crypto/hash/hmac_ossl.c

03e0b72a56d060990e7db656a8eb92550a5eed30 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/03e0b72a56d060990e7db656a8eb92550a5eed30
Authored: 2021-12-10 18:25:07 +0100
Committed: 2021-12-10 18:25:07 +0100

set include path to be relative not absolute

and remove some whitespace

Files Modified:

  • CMakeLists.txt

0d1ec9971cbaebdf9864c1c1a48e3e135e5fb708 by Yann Droneaud

https://github.com/cisco/libsrtp/commit/0d1ec9971cbaebdf9864c1c1a48e3e135e5fb708
Authored: 2021-12-10 10:50:13 +0100
Committed: 2021-12-10 10:50:16 +0100

EVP_CIPHER_CTX_cleanup() is deprecated in OpenSSL 1.1.0

Starting from OpenSSL 1.1.0, EVP_CIPHER_CTX_cleanup()
and EVP_CIPHER_CTX_init() are deprecated, and not
available when OpenSSL is built with "no-deprecated"
option (aka. OPENSSL_NO_DEPRECATED).

Use EVP_CIPHER_CTX_reset() instead:

"EVP_CIPHER_CTX was made opaque in OpenSSL 1.1.0.
As a result, EVP_CIPHER_CTX_reset() appeared and
EVP_CIPHER_CTX_cleanup() disappeared."

https://www.openssl.org/docs/man1.1.1/man3/EVP_CIPHER_CTX_reset.html

Files Modified:

  • crypto/cipher/aes_gcm_ossl.c
  • crypto/cipher/aes_icm_ossl.c

b156e95032dcf118cf98830b6bd514270c355d18 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/b156e95032dcf118cf98830b6bd514270c355d18
Authored: 2021-12-10 08:42:27 +0100
Committed: 2021-12-10 08:42:27 +0100

Update autotools.yml

Same update for autotools yml

Files Modified:

  • .github/workflows/autotools.yml

d11035441aca0096105a643851b686af0f2877f1 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/d11035441aca0096105a643851b686af0f2877f1
Authored: 2021-12-10 08:34:53 +0100
Committed: 2021-12-10 08:34:53 +0100

Update cmake.yml

Seems and update is now needed before installing nss on Ubuntu

Files Modified:

  • .github/workflows/cmake.yml

c3db75c3c4317a5a2901c7876a3dcc86a9b534e1 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/c3db75c3c4317a5a2901c7876a3dcc86a9b534e1
Authored: 2021-12-09 16:29:57 -0500
Committed: 2021-12-09 16:29:57 -0500

clang-format

Files Modified:

  • srtp/srtp.c

2542d684ce351f1acb27309aaeb5c615c63d1469 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/2542d684ce351f1acb27309aaeb5c615c63d1469
Authored: 2021-12-09 16:19:43 -0500
Committed: 2021-12-09 16:19:43 -0500

Fix key sizes in null cipher test policies

Files Modified:

  • srtp/srtp.c
  • test/srtp_driver.c

f1d1e57a49dca345e086e01b5fccc44e723221e0 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/f1d1e57a49dca345e086e01b5fccc44e723221e0
Authored: 2021-12-09 15:40:18 -0500
Committed: 2021-12-09 15:40:18 -0500

Correctly set null cipher key sizes

Files Modified:

  • srtp/srtp.c

db4dc8973394b5b370f549512d578e720b8870b9 by Andrey Semashev

https://github.com/cisco/libsrtp/commit/db4dc8973394b5b370f549512d578e720b8870b9
Authored: 2021-11-17 16:16:38 +0300
Committed: 2021-11-17 16:20:29 +0300

Avoid initializing local char table when converting nibble to hex.

Files Modified:

  • crypto/math/datatypes.c

9345ca5c1080bb14f5b17aa035d0b0728d9f4883 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/9345ca5c1080bb14f5b17aa035d0b0728d9f4883
Authored: 2021-10-28 20:40:04 +0200
Committed: 2021-10-28 20:40:04 +0200

test for out of order after rollover

This is a test case to check if issue #567 is
reproducible.

Files Modified:

  • test/srtp_driver.c

921159ed1f35d098bd5e436630550939928a530a by Pascal Bühler

https://github.com/cisco/libsrtp/commit/921159ed1f35d098bd5e436630550939928a530a
Authored: 2021-10-27 20:58:35 +0200
Committed: 2021-10-27 21:21:45 +0200

add compile time check of format arguments to srtp_err_report()

Files Modified:

  • crypto/include/err.h

3291018b0dffee1a07d79b2c3496ec55c28b7734 by Alexander Traud

https://github.com/cisco/libsrtp/commit/3291018b0dffee1a07d79b2c3496ec55c28b7734
Authored: 2021-10-14 17:02:31 +0200
Committed: 2021-10-14 17:02:31 +0200

Update README.md to include NSS

Files Modified:

  • README.md

38f5ccb11453fc2d612b06aa7a506c28d8f8363f by SE2Dev

https://github.com/cisco/libsrtp/commit/38f5ccb11453fc2d612b06aa7a506c28d8f8363f
Authored: 2021-10-13 22:45:11 +0000
Committed: 2021-10-13 22:59:43 +0000

Export CMake Targets

Files Added:

  • Config.cmake.in

Files Modified:

  • CMakeLists.txt

52de41970582ec69f94fa32ec62f84a70dbd6345 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/52de41970582ec69f94fa32ec62f84a70dbd6345
Authored: 2021-10-11 10:40:26 +0200
Committed: 2021-10-11 10:47:04 +0200

cast time_t values to known types for formatting in fprintf

This is a fix suggested in issue #566 to address build issues
with debian x32.

Files Modified:

  • test/rtp_decoder.c

1e7b25f4a957e290d362c3e67afa2c8bac8be82c by Stepan Saiko

https://github.com/cisco/libsrtp/commit/1e7b25f4a957e290d362c3e67afa2c8bac8be82c
Authored: 2021-10-10 13:33:52 +0500
Committed: 2021-10-10 13:33:52 +0500

Include directory should point to 'include' not to 'include/srtp2'

Files Modified:

  • include/srtp2/meson.build
  • meson.build

3a5d26c45c7a5a60c78d6ee60d409ff464f629fd by Lorenzo Miniero

https://github.com/cisco/libsrtp/commit/3a5d26c45c7a5a60c78d6ee60d409ff464f629fd
Authored: 2021-09-13 16:13:45 +0200
Committed: 2021-09-13 16:13:45 +0200

Fix typo introduced by PR 559

Files Modified:

  • srtp/srtp.c

6213c42753f8101dae34688551557d6c172930e2 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/6213c42753f8101dae34688551557d6c172930e2
Authored: 2021-08-19 11:55:28 +0200
Committed: 2021-09-10 08:31:58 +0200

rtp_decoder: support setting SSRC and initial ROC

This allows decryption of pcap's that do not contain the
beginning of the RTP stream, where the sequence number may have
already wrapped.
In order to set a initial ROC then the SSRC is also required.

Files Modified:

  • test/rtp_decoder.c
  • test/rtp_decoder.h

3fba14d14f09f152dbd797eefa3f99d2048f3e4f by Pascal Bühler

https://github.com/cisco/libsrtp/commit/3fba14d14f09f152dbd797eefa3f99d2048f3e4f
Authored: 2021-08-19 09:25:50 +0200
Committed: 2021-09-10 08:31:58 +0200

change argument for setting crypto suite to -c

This will break existing usage of the tool but the
breakage will not be silent, it will produce an error.
The impact of this change should be small as it is assumed
that there are not many users of this tool.

Files Modified:

  • test/rtp_decoder.c

096166c0fb1f444a852cf75cfbfd4636a9d43ead by Pascal Bühler

https://github.com/cisco/libsrtp/commit/096166c0fb1f444a852cf75cfbfd4636a9d43ead
Authored: 2021-08-18 21:49:02 +0200
Committed: 2021-09-10 08:31:58 +0200

add rtp_decoder to cmake build

This will build as part of test apps.
A very simple find PCAP package is supported. This should be
sufficient as it is a seldom used test tool. It can be expanded
as needed.

Files Added:

  • cmake/FindPCAP.cmake

Files Modified:

  • CMakeLists.txt

812a683c8554f53b80f64b94966c790c59b7de32 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/812a683c8554f53b80f64b94966c790c59b7de32
Authored: 2021-09-09 08:46:15 -0400
Committed: 2021-09-09 08:46:15 -0400

Set full-size key length in crypto policies

Files Modified:

  • srtp/srtp.c

c4a54553babd170d2e00c06d81017c76da4a7bad by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/c4a54553babd170d2e00c06d81017c76da4a7bad
Authored: 2021-09-09 08:38:48 -0400
Committed: 2021-09-09 08:38:48 -0400

Set full-size key length in crypto policies

Files Modified:

  • srtp/srtp.c

f3830315d6770ef51223d3483d859193c31ca220 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/f3830315d6770ef51223d3483d859193c31ca220
Authored: 2021-09-08 17:51:11 -0400
Committed: 2021-09-08 17:51:11 -0400

Formatting

Files Modified:

  • srtp/srtp.c

15e64b9c935f2d5ea94e758527b509a9727ea8ae by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/15e64b9c935f2d5ea94e758527b509a9727ea8ae
Authored: 2021-09-08 17:46:51 -0400
Committed: 2021-09-08 17:46:51 -0400

Accommodate shorter GCM keys

Files Modified:

  • srtp/srtp.c

89a5f706305649aac2942f602e9e45ea9bca5da0 by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/89a5f706305649aac2942f602e9e45ea9bca5da0
Authored: 2021-09-08 11:36:03 -0400
Committed: 2021-09-08 11:47:09 -0400

Use a full-length key even with null ciphers

Files Modified:

  • srtp/srtp.c
  • test/srtp_driver.c

54d1d7a6daa8fae35460cddf71ef69bed3b21e78 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/54d1d7a6daa8fae35460cddf71ef69bed3b21e78
Authored: 2021-08-31 23:51:16 +0200
Committed: 2021-08-31 23:51:16 +0200

reset pending_roc when advancing packet index and protecting using gcm

This code now has the same behavior as none gcm ciphers.

Files Modified:

  • srtp/srtp.c

c184423b5e32e29dfa301ec7c876023b1ea64a13 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/c184423b5e32e29dfa301ec7c876023b1ea64a13
Authored: 2021-08-31 23:40:14 +0200
Committed: 2021-08-31 23:42:01 +0200

run set roc test with gcm if available

This will exercise both gcm and non gcm code paths in ci.

Files Modified:

  • test/srtp_driver.c

403cbc63aad5f239b546d90efd56fe4d0f98cde5 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/403cbc63aad5f239b546d90efd56fe4d0f98cde5
Authored: 2021-08-31 23:34:10 +0200
Committed: 2021-08-31 23:34:10 +0200

reset pending_roc when advancing packet index when using gcm

This code now has the same behavior as none gcm ciphers.

Files Modified:

  • srtp/srtp.c

4bf8c515b5cc40a58108b911c097ee17ff7406f1 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/4bf8c515b5cc40a58108b911c097ee17ff7406f1
Authored: 2021-08-31 22:25:01 +0200
Committed: 2021-08-31 23:04:31 +0200

add set ROC then rollover test that fails for gcm only

Files Modified:

  • test/srtp_driver.c

20bb61190fa28d4a28382cbbd7b3d2e1658f87ab by Pascal Bühler

https://github.com/cisco/libsrtp/commit/20bb61190fa28d4a28382cbbd7b3d2e1658f87ab
Authored: 2021-08-19 13:59:37 +0200
Committed: 2021-08-19 14:01:58 +0200

update format check to use clang-format-10

Files Added:

  • .github/workflows/format_check.yml

Files Deleted:

  • .github/workflows/fromat_check.yml

Files Modified:

  • crypto/cipher/aes.c
  • crypto/cipher/aes_icm.c
  • crypto/replay/rdbx.c
  • crypto/test/aes_calc.c
  • crypto/test/sha1_driver.c
  • format.sh
  • srtp/srtp.c
  • test/rtp.h
  • test/rtp_decoder.c
  • test/rtpw.c
  • test/srtp_driver.c

08077b70c8ac65d11f9ec9cc77f19c6629a30e88 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/08077b70c8ac65d11f9ec9cc77f19c6629a30e88
Authored: 2021-08-16 15:52:56 +0200
Committed: 2021-08-16 15:52:56 +0200

Update README.md

Files Modified:

  • README.md

82688d4195011fd64f2bb80c6f62e3a2eacb827c by Pascal Bühler

https://github.com/cisco/libsrtp/commit/82688d4195011fd64f2bb80c6f62e3a2eacb827c
Authored: 2021-08-16 15:51:15 +0200
Committed: 2021-08-16 15:51:15 +0200

Update cmake.yml

Files Modified:

  • .github/workflows/cmake.yml

392e1001d1ec973e9044a6960cb5e0d6ae1e4771 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/392e1001d1ec973e9044a6960cb5e0d6ae1e4771
Authored: 2021-08-16 14:21:42 +0200
Committed: 2021-08-16 15:15:54 +0200

trigger coverity scan for pushes into master

Files Added:

  • .github/workflows/coverity_scan.yml

99f180a25d31f5955c49cb61026707cee0cd6e06 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/99f180a25d31f5955c49cb61026707cee0cd6e06
Authored: 2021-08-16 12:24:22 +0200
Committed: 2021-08-16 13:33:08 +0200

add action for autotools ci

Files Added:

  • .github/workflows/autotools.yml

1057a19f919b3860fc8a82904cfcb531d2a11522 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/1057a19f919b3860fc8a82904cfcb531d2a11522
Authored: 2021-08-16 11:56:27 +0200
Committed: 2021-08-16 11:56:27 +0200

ensure the build for fuzzing works

Files Added:

  • .github/workflows/fuzzer_build.yml

1be3073201ed8a76af658e35b50d8783400958a8 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/1be3073201ed8a76af658e35b50d8783400958a8
Authored: 2021-08-16 10:33:08 +0200
Committed: 2021-08-16 10:33:08 +0200

try with older ubuntu release

Files Modified:

  • .github/workflows/fromat_check.yml

780c8be7a7e6d4297ac9ba35c7ebe45ed813c623 by Pascal Bühler

https://github.com/cisco/libsrtp/commit/780c8be7a7e6d4297ac9ba35c7ebe45ed813c623
Authored: 2021-08-16 10:17:08 +0200
Committed: 2021-08-16 10:17:08 +0200

Create fromat_check.yml

Files Added:

  • .github/workflows/fromat_check.yml

383329c8101d0558744a1d4223fe4206064b362e by Pascal Buhler

https://github.com/cisco/libsrtp/commit/383329c8101d0558744a1d4223fe4206064b362e
Authored: 2021-08-13 21:20:31 +0200
Committed: 2021-08-13 21:20:31 +0200

Update version to 2.5.0-pre

Files Modified:

  • CMakeLists.txt
  • configure
  • configure.ac
  • meson.build

afcad687b7483c31693d7eb3ba5b0385504919ab by Richard L. Barnes

https://github.com/cisco/libsrtp/commit/afcad687b7483c31693d7eb3ba5b0385504919ab
Authored: 2021-08-11 08:35:43 -1000
Committed: 2021-08-11 08:53:32 -1000

Count blocks instead of bytes in AES-ICM limit computation

Files Modified:

  • crypto/cipher/aes_icm.c
Assignee: nobody → tom
Status: NEW → ASSIGNED

./mach vendor produced output so long that Bugzilla kicked back the comment. I've run the patch myself and attached it. A try run is at https://treeherder.mozilla.org/jobs?repo=try&revision=3a3a41b4942c944800507e8f3aa8825167a8cf58

Assignee: tom → rjesup
See Also: → 1814442

Updatebot has encountered an unknown error and does not know how to further
process this library update. Please review and take manual action for this update.

The Updatebot maintainers have been notified and Updatebot will no longer process
this update.

status-firefox112: --- → affected

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(rjesup)
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/autoland/rev/2d8dccdd0d5f
Update libsrtp to v2.5.0 from 2023-02-01 08:25:02 r=jesup

Backed out changeset 2d8dccdd0d5f (bug 1814375) for causing multiple build bustages.

Flags: needinfo?(rjesup)
Flags: needinfo?(rjesup) → needinfo?(tom)

Note:: I haven't looked at what the issue is

Flags: needinfo?(docfaraday)

./mach vendor isn't foolproof, we always need to look at the patch for both build failures and general code review like you would anyone's patch. I think what happened here is that config.h is a file produced by libsrtp's makefile; so it isn't checked into upstream and we don't generate it. Instead we had a stub file in the repo. Which was removed during mach vendor's update.

We can probably fix this by adding it to a keep list here such as with libtheora.

Flags: needinfo?(tom)
status-firefox113: --- → affected
status-firefox114: --- → affected
status-firefox115: --- → affected
status-firefox116: --- → affected
status-firefox117: --- → affected
status-firefox118: --- → affected

Depends on D168568

Attachment #9348612 - Attachment is obsolete: true
status-firefox119: --- → affected
status-firefox120: --- → affected
status-firefox121: --- → affected
status-firefox122: --- → affected
status-firefox123: --- → affected
status-firefox124: --- → affected
status-firefox125: --- → affected

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Duplicate of bug: 1881905
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: