1814389 - Update speculative connection tests to ensure they cover all cases

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Andrew Creskey [:acreskey]]

We discovered in bug 1813618 that speculative connections were being cancelled.

This bug is to add a test to verify that connections are being made and to ensure that we don't disable them in the general case.

Comment 1

[Andrew Creskey [:acreskey]]

We do have quite a few tests that verify speculative connections.

browser/components/sessionstore/test/browser_speculative_connect.js
browser/components/urlbar/tests/browser/browser_speculative_connect.js

The above tests pass because of the codepaths they use and also because some of the tests are to http and not https urls.
Bug 1813618 on affects https connections.

We also have these tests which rely on the ​​"speculative-connect-request" topic being broadcast:
netwerk/test/browser/browser_103_preconnect.js
netwerk/test/mochitests/test_rel_preconnect.html
toolkit/components/extensions/test/xpcshell/test_ext_proxy_speculative.js

But I think the problem is that the topic can be broadcast even if we later abort the speculative connection.

Comment 2

[Andrew Creskey [:acreskey]]

The timing of the broadcast of the ​​"speculative-connect-request" topic was already improved in the fix for Bug 1543990.
See here - we no longer emit the topic and then abort under some circumstances.

Comment 3

[Andrew Creskey [:acreskey]]

Fixed with Bug 1838498 and Bug 1818798.