Closed Bug 1814645 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38326 - Remove NOTREACHED in HttpCache::Transaction

Categories

(Core :: DOM: Networking, task, P4)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38326 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38326
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

Remove NOTREACHED in HttpCache::Transaction

net::HttpCache::Transaction::BeginCacheRead had a NOTREACHED() statement
which is reached if a range request is sent with "only-if-cached" as the
cache mode.

Remove the NOTREACHED() and permit the fallthrough behaviour of
returning ERR_CACHE_MISS to happen instead.

Add unit and web-platform tests for this case.

BUG=1408233

Change-Id: I1023712b1a0d3642e6c980dd12dba81440d4fc13
Reviewed-on: https://chromium-review.googlesource.com/4218212
WPT-Export-Revision: 2643f69918b02cc7f410ba693f0b435109f497b6

Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 9 subtests

Status Summary

Firefox

OK : 4
FAIL: 36

Chrome

OK : 4
PASS: 12
FAIL: 24

Safari

OK : 4
FAIL: 36

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fetch/http-cache/partial.any.html [wpt.fyi]
    • HTTP cache stores partial content and reuses it: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it with only-if-cached: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial content and completes it: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/http-cache/partial.any.sharedworker.html [wpt.fyi]
    • HTTP cache stores partial content and reuses it: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it with only-if-cached: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial content and completes it: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/http-cache/partial.any.worker.html [wpt.fyi]
    • HTTP cache stores partial content and reuses it: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it with only-if-cached: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial content and completes it: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/http-cache/partial.any.serviceworker.html [wpt.fyi]
    • HTTP cache stores partial content and reuses it: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: PASS, Safari: FAIL)
    • HTTP cache stores complete response and serves smaller ranges from it with only-if-cached: FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (absent last-byte-pos): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial response and serves smaller ranges from it (suffix-byte-range-spec): FAIL (Chrome: FAIL, Safari: FAIL)
    • HTTP cache stores partial content and completes it: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/996509180dbe [wpt PR 38326] - Remove NOTREACHED in HttpCache::Transaction, a=testonly https://hg.mozilla.org/integration/autoland/rev/d3208780e602 [wpt PR 38326] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/996509180dbe
https://hg.mozilla.org/mozilla-central/rev/d3208780e602

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.