1814703 - Allow selecting Windows ARM64 clearkey plugin over x86 via pref

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Right now we default to using the x86 clearkey plugin on Windows ARM. With our potential move to using the ARM Widevine plugin, we should allow testing to select the ARM clearkey plugin.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1814703 - Allow selecting between ARM and x86 clearkey on Windows ARM.

On Windows ARM, we currently use the x86 version of the clearkey plugin.
We do however ship Firefox with the ARM version although prior to this
patch it was unused. Now if media.gmp-clearkey.allow-x64-plugin-on-arm64
is set to false, then we will attempt to load the ARM version of the
plugin. The pref remains true by default.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66a6c82bbc21
Allow selecting between ARM and x86 clearkey on Windows ARM. r=azebrowski

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/66a6c82bbc21

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9315668 [details]
Bug 1814703 - Allow selecting between ARM and x86 clearkey on Windows ARM.

Beta/Release Uplift Approval Request

• User impact if declined: Any streaming site depending on Widevine and Clearkey plugins are broken with the x86 plugins on Windows ARM. Uplifting the requested set will allow us to roll out a switch to the ARM plugins instead.

Visiting any DRM protected streaming site will crash the plugin process, and the user will be unable to play content.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1814910, Bug 1819661, Bug 1814703, Bug 1819661, Bug 1820669, Bug 1819410
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because we have verified this in 112 in both nightly and beta with no issues reported by QA. GMP plugins are already completely broken for Windows ARM users.
• String changes made/needed:
• Is Android affected?: No

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Any streaming site depending on Widevine and Clearkey plugins are broken with the x86 plugins on Windows ARM. Uplifting the requested set will allow us to roll out a switch to the ARM plugins instead.
• User impact if declined: Visiting any DRM protected streaming site will crash the plugin process, and the user will be unable to play content.
• Fix Landed on Version: 112
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because we have verified this in 112 in both nightly and beta with no issues reported by QA. GMP plugins are already completely broken for Windows ARM users.

Depends on:
Bug 1811981, Bug 1814910, Bug 1819661, Bug 1814703, Bug 1819661, Bug 1820669, Bug 1819410

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9315668 [details]
Bug 1814703 - Allow selecting between ARM and x86 clearkey on Windows ARM.

Approved for 102.10esr

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/f1f54d72daf3

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9315668 [details]
Bug 1814703 - Allow selecting between ARM and x86 clearkey on Windows ARM.

Approved for 111.0.1

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-release/rev/f36ee807b2c0