Closed Bug 1814715 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38334 - Revert "Reland "Reject getDisplayMedia calls without user activation""

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox111 fixed)

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 38334 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38334
Details from upstream follow.

Fr <beaufort.francois@gmail.com> wrote:

Revert "Reland "Reject getDisplayMedia calls without user activation""

This reverts commit cdf104c2c9bec928fe578719836cab8d5815759e.

Reason for revert: This change breaks websites

Original change's description:

Reland "Reject getDisplayMedia calls without user activation"

This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1.

Reason for revert: This CL also now fixes permission policy tests
by making them run in sequences so that the emulated click is not
lost across tests.

Original change's description:

Revert "Reject getDisplayMedia calls without user activation"

This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf.

Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7.

The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related.

Original change's description:

Reject getDisplayMedia calls without user activation

This CL makes sure getDisplayMedia() returned promise reject with
InvalidStateError when called without user activation.
Note that speculation rules tests are updated as well[1].

[1] https://github.com/WICG/nav-speculation/issues/225

Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI

Bug: 1198918
Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797
Reviewed-by: Dale Curtis \<dalecurtis@chromium.org>
Reviewed-by: Hiroki Nakagawa \<nhiroki@chromium.org>
Reviewed-by: Elad Alon \<eladalon@chromium.org>
Commit-Queue: Fr \<beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1086033}

Bug: 1198918
Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423
Auto-Submit: Peter Williamson \<petewil@chromium.org>
Quick-Run: Peter Williamson \<petewil@chromium.org>
Commit-Queue: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Peter Williamson \<petewil@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1086147}

Bug: 1198918
Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755
Commit-Queue: Fr \<beaufort.francois@gmail.com>
Reviewed-by: Elad Alon \<eladalon@chromium.org>
Reviewed-by: Hiroki Nakagawa \<nhiroki@chromium.org>
Reviewed-by: Dale Curtis \<dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1095545}

Bug: 1198918,1412364
Bug: b:267183725
Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651
Reviewed-by: Dale Curtis \<dalecurtis@chromium.org>
Commit-Queue: Fr \<beaufort.francois@gmail.com>
Reviewed-by: Elad Alon \<eladalon@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1100530}

Attached file Notable wpt changes
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 88 tests and 7 subtests ## Status Summary ### Firefox `OK` : 59 `PASS` : 56 `FAIL` : 521 `TIMEOUT`: 82 `ERROR` : 5 `NOTRUN` : 16 ### Chrome `OK` : 70 `PASS` : 222 `CRASH` : 6 `FAIL` : 395 `TIMEOUT`: 26 `ERROR` : 4 `NOTRUN` : 16 ### Safari `OK` : 57 `PASS` : 55 `FAIL` : 512 `TIMEOUT`: 84 `ERROR` : 5 `NOTRUN` : 16 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=a3e46feb61b6c3d31c312c45f0c1626aea860892&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=a3e46feb61b6c3d31c312c45f0c1626aea860892&label=pr_base) ## Details ### Firefox-only Failures * [/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html)] * permissions policy allow="payment" allows same-origin navigation in an iframe.: `FAIL` * permissions policy allow="payment" allowpaymentrequest=true allows same-origin navigation in an iframe.: `FAIL` * [/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html)] * permissions policy "payment" can be enabled in same-origin iframe using allow="payment" attribute: `FAIL` * [/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html)] * permissions policy header "payment=*" allows the top-level document.: `FAIL` * permissions policy header "payment=*" allows same-origin iframes.: `FAIL` * [/permissions-policy/payment-default-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/payment-default-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-default-permissions-policy.https.sub.html)] * Default "payment" permissions policy allows the top-level document.: `FAIL` * Default "payment" permissions policy allows same-origin iframes.: `FAIL` * Default "payment" permissions policy allowpaymentrequest=true allows same-origin iframes.: `FAIL` * [/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html)] * permissions policy allow="picture-in-picture" disallows cross-origin navigation in an iframe.: `FAIL` * [/permissions-policy/picture-in-picture-disabled-by-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-disabled-by-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-disabled-by-permissions-policy.https.sub.html)] * permissions policy header: picture-in-picture "none" disallows the top-level document.: `FAIL` * permissions policy header: picture-in-picture "none" disallows same-origin iframes.: `FAIL` * permissions policy header: picture-in-picture "none" disallows cross-origin iframes.: `FAIL` * [/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html](https://wpt.live/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html) [[wpt.fyi](https://wpt.fyi/results/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html)] * Permissions-Policy header "screen-wake-lock=()" disallows the top-level document.: `FAIL` (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7bf6f4c9643 [wpt PR 38334] - Revert "Reland "Reject getDisplayMedia calls without user activation"", a=testonly https://hg.mozilla.org/integration/autoland/rev/865bd980f040 [wpt PR 38334] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: