Closed Bug 1814808 Opened 3 years ago Closed 3 years ago

Move chunk releasing out of the arena lock's critical section

Categories

(Core :: Memory Allocator, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: pbone, Assigned: pbone)

References

(Blocks 1 open bug)

Details

(Keywords: perf:responsiveness, Whiteboard: [sp3])

Attachments

(1 file)

No description provided.

The system calls of releasing a chunk of memory can be costly and should be
done outside the arena lock's critical section so that other threads aren't
blocked waiting for the lock.

Performance results show some improvments on browser time tests on most pages, regressions on some pages, both mostly on Windows. No change on AWSY or Speedometer. There are some outlier results for speedometer on MacOS but they're too "lucky".

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=997050d52fd95aaf533fbc4d3983c37511f8ca3f&newProject=try&newRevision=2d554cb42a561ea166f1f08540304a6c5ee85173&framework=13&page=1&filter=speedometer

Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/850b602e5051 Move chunk releasing out of the arena lock's critical section r=glandium
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: