1814811 - Fix out-of-process WebGL rendering by RenderAndroidSurfaceTextureHost and WebRender (Software OpenGL)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sotaro Ikeda [:sotaro]]

I noticed the problem during working for Bug 1813267.

WebGL rendering became upside down with WebRender (Software OpenGL) by disabling external compositing.

Comment 1

[Sotaro Ikeda [:sotaro]]

It is a regression by bug 1793679.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1814811 - Fix out-of-process WebGL rendering by RenderAndroidSurfaceTextureHost and WebRender (Software OpenGL)

Comment 3

[Sotaro Ikeda [:sotaro]]

2 problems existed.

• [1] RenderAndroidSurfaceTextureHost::GetUvCoords() was not called when RenderAndroidSurfaceTextureHost is wrapped by RenderTextureHostWrapper.
• [2] NeedsYFlip() of SurfaceTextureHost::CreateRenderTexture() uses TextureHost::mFlags. But TextureHost::mFlags was updated by RemoteTextureHostWrapper::ApplyTextureFlagsToRemoteTexture() after SurfaceTextureHost::CreateRenderTexture() call. Then RenderAndroidSurfaceTextureHost::mOriginPos became wrong.

[1] is addressed by adding RenderTextureHostWrapper::GetUvCoords()

[2] is addressed by removing RenderAndroidSurfaceTextureHost::mOriginPos. It is not necessary since Bug 1731980.

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&revision=378690475287c64bf49d26839f1d2f895f8c231a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07a561fc373c
Fix out-of-process WebGL rendering by RenderAndroidSurfaceTextureHost and WebRender (Software OpenGL) r=lsalzman,gfx-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/07a561fc373c