1814821 - [Wayland] Context menu flickers when it's opened upwards exceeding the browser window

Status: RESOLVED DUPLICATE of bug 1814239

(Core :: Widget: Gtk, defect)

Description

[q23456yuiop]

Steps to reproduce:

1. Resize the firefox window so that context menus opened will exceed the border of the firefox window.
2. Put the window at the bottom of the screen.
3. Right click somewhere to open a context menu.
4. Observe that the menu flickers.

Environment: GNOME Wayland on Arch Linux, mutter 43.2.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1798697, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

This seems fundamentally the same issue described in bug 1813407 comment 3, and repros in other popups on release (so without my change...)

Comment 4

[q23456yuiop]

repros in other popups on release (so without my change...)

TBH I have been running the nightly firefox on wayland and haven't seen any flickering since months ago...

Is there a chance that some parts of your patch will be limited to cocoa?

Comment 5

[Emilio Cobos Álvarez [:emilio]]

I also run Wayland and didn't see the flickering, but I just noticed that I had missed step 3 of your steps. Let me try to reproduce.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Ah, I see what's going on, bug 1814239 fixes this. The issue is that the rounding code doesn't deal well with negative integers. I added a test for this there.

Comment 7

[Daniel Holbert [:dholbert]]

FWIW, I was hitting a similar-sounding bug (in Ubuntu 22.04 on Wayland), which also regressed from bug 1798697, and I confirmed that bug 1814239 fixes my issue. Hooray!

My STR:
(1) Visit about:preferences and search for "fonts"
(2) Click the button to open the "Default font" menu
(3) If the menu appears, then try moving the Firefox window closer to the bottom of the screen, and then try clicking the "default font" menu button again.

ACTUAL RESULTS:
The menu popup would mostly never appear (at least, not after I moved the Firefox window near the bottom of the screen). Doesn't matter if I open with a single-click vs. click-and-hold; it doesn't show up either way. Sometimes it would flash very briefly, but not really usefully appear. It would also end up choosing some arbitrary menu item that I presumably happened to be hovering over.

EXPECTED RESULTS:
Menu popup should reliably appear.

The most recent Nightly reproduces my issue, but I ran the somewhat-newer taskcluster build with bug 1814239's fix (using mozregression --launch cb43aceda841) and I wasn't able to reproduce my problem there. (Though I do still see bug 1815370, a distinct issue with the same piece of UI.)