1814896 - Release geckodriver 0.32.2 with marionette 0.3.0 ("cargo install geckodriver" is broken for 0.31.0 and 0.32.0 releases)

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As reported on Matrix by khuey geckodriver cannot be build anymore for the 0.31.0 and 0.32.0 releases via cargo install. The following command will fail:

cargo install --version 0.31.0 geckodriver

The reason is the change from bug 1811996 and that we did a semver incompatible version bump for the Marionette crate when releasing geckodriver 0.32.1 via bug 1794560.

error: could not compile `geckodriver` due to 9 previous errors
error: failed to compile `geckodriver v0.32.0`, intermediate artifacts can be found at `/var/folders/sd/hgkqcwv90sz_q1pqjww78nfm0000gn/T/cargo-install55mx5A`

We should decide what to do here. Most likely we should yank the marionette 0.2.1 crate and geckodriver 0.31.1 after releasing a new 0.31.2 release.

Lets discuss on Monday in our triage meeting.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

To prevent such regressions we could run cargo semver-checks check-release for each of the dependency crates as part of Update in-tree dependency crates. The tool needs to be installed once via cargo install cargo-semver-checks --locked (website).

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1814896 - [rust-marionette] Relase version 0.3.0.

The release of version 0.2.1 didn't obey the semver rules and
introduced a backward incompatible bug. As such we have to
release a minor release now.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1814896 - [geckodriver] Release version 0.32.2.

Depends on D168984

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1814896 - [geckodriver] Update changeset for the 0.32.2 release.

Depends on D168985

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1a9e1ce2ebd
[rust-marionette] Relase version 0.3.0. r=webdriver-reviewers,supply-chain-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/a0aa366f7f06
[geckodriver] Release version 0.32.2. r=webdriver-reviewers,jgraham

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f1a9e1ce2ebd
https://hg.mozilla.org/mozilla-central/rev/a0aa366f7f06

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The merge to mozilla-central was done as part of 602aa16c20d4.

Once all the signed geckodriver builds are ready I will do the release.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b545bf471941
[geckodriver] Update changeset for the 0.32.2 release. r=webdriver-reviewers,jgraham DONTBUILD

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Upstream import: https://github.com/mozilla/geckodriver/pull/2083

Version v0.32.2 is released: https://github.com/mozilla/geckodriver/releases/tag/v0.32.2

Crates have been published to crates.io:

Uploading marionette v0.3.0
Uploading geckodriver v0.32.2

Next step is to yank the broken crates from crates.io and to check that everything builds fine again.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yanked the following crates:

• https://crates.io/crates/marionette/0.2.1
• https://crates.io/crates/geckodriver/0.32.1

Made the announcement on the mailing list:
https://groups.google.com/a/mozilla.org/g/dev-webdriver/c/XXN5L8JptEk

I'm going to leave the bug open until the remaining commit got merged to mozilla-central.

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b545bf471941