1814908 - Have a way to disable capturing all the stacks of profiler markers

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P1)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

During speedometer3 profiling, some markers with stacks can really skew the profile data because of the overhead of capturing the stacks. We should have a way to disable capturing stacks for profiler markers with either using a pref or a feature in the about:profiling page. That way people who are profiling speedometer3 will have more accurate data.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1814908 - Rename the noiostacks to nomarkerstacks r?julienw,mstange

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1814908 - Reword the nomarkerstacks feature name and description r?florian,julienw

Depends on D169110

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1814908 - Do not collect the marker stacks if NoMarkerStacks feature is set r?julienw,mstange

Depends on D169111

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1814908 - Remove the custom handling for the File IO markers r?julienw,mstange

Depends on D169112

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1a9a1820b56
Rename the noiostacks to nomarkerstacks r=julienw
https://hg.mozilla.org/integration/autoland/rev/a8557338bd74
Reword the nomarkerstacks feature name and description r=florian,julienw
https://hg.mozilla.org/integration/autoland/rev/6a716b16e8e3
Do not collect the marker stacks if NoMarkerStacks feature is set r=julienw,mstange
https://hg.mozilla.org/integration/autoland/rev/4fd5e3f3d87b
Remove the custom handling for the File IO markers r=julienw

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing cppunit failures on TestBaseProfiler

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78e1485fe526
Rename the noiostacks to nomarkerstacks r=julienw
https://hg.mozilla.org/integration/autoland/rev/d9bdfd2796a8
Reword the nomarkerstacks feature name and description r=florian,julienw
https://hg.mozilla.org/integration/autoland/rev/14f79f14b429
Do not collect the marker stacks if NoMarkerStacks feature is set r=julienw,mstange
https://hg.mozilla.org/integration/autoland/rev/07252e8b15df
Remove the custom handling for the File IO markers r=julienw

Comment 8

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Fixed the cppunittest issue.

Comment 9

[Atila Butkovits]

Backed out for causing Xpcshell failures at test_addProfilerMarker.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a8fff673c1115126ad4ff82bce45c1bbfca5cf3c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=RRsUqEGyTUSIgRLxrAitCg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=07252e8b15df15fba8416bd23bad3daf9537294b

Failure log: https://treeherder.mozilla.org/logviewer?job_id=405597466&repo=autoland&lineNumber=3779

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e9c5e044680
Rename the noiostacks to nomarkerstacks r=julienw
https://hg.mozilla.org/integration/autoland/rev/747ee43e22dd
Reword the nomarkerstacks feature name and description r=florian,julienw
https://hg.mozilla.org/integration/autoland/rev/cb9aad1b3e72
Do not collect the marker stacks if NoMarkerStacks feature is set r=julienw,mstange
https://hg.mozilla.org/integration/autoland/rev/8a9833a79468
Remove the custom handling for the File IO markers r=julienw

Comment 11

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

That failure was related to an assertion I was adding. Fixed it and relanded.

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4e9c5e044680
https://hg.mozilla.org/mozilla-central/rev/747ee43e22dd
https://hg.mozilla.org/mozilla-central/rev/cb9aad1b3e72
https://hg.mozilla.org/mozilla-central/rev/8a9833a79468

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

And verified, this is great, thanks!