1814980 - Consider increasing or removing MAX_OMNIBOX_RESULT_COUNT

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Gregory Pappas [:gregp]]

MAX_OMNIBOX_RESULT_COUNT (formerly known as MAXIMUM_ALLOWED_EXTENSION_MATCHES) has had the same value of 6 since being introduced in bug 1267810. Per bug 1267810 comment 29, this was the same limit Chromium had. Unfortunately, this is no longer the case. Chromium now allows a maximum of 10 visible results.

I think we should align with this change, either by increasing MAX_OMNIBOX_RESULT_COUNT or by removing it. I think we should remove it, as browser.urlbar.maxRichResults already has a default value of 10.

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1814980 - Remove MAX_OMNIBOX_RESULT_COUNT r?adw!

MAX_OMNIBOX_RESULT_COUNT was introduced in bug 1267810 to increase compatibility with Chromium. It no longer serves this purpose as Chromium has since removed its limit of 6 extension-supplied results.

Comment 2

[Tomislav Jovanovic :zombie]

Looks like this is all in search code.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4b852d0732c
Remove MAX_OMNIBOX_RESULT_COUNT r=adw

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset d4b852d0732c (Bug 1814980) for causing xpc failures in test_providerOmnibox.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=ePMX7USIQOGw_bwuDDCecA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d4b852d0732c561b1692f0995934a8c4bb28f9d7

Log: https://treeherder.mozilla.org/logviewer?job_id=404889913&repo=autoland&lineNumber=3776

Backout: https://hg.mozilla.org/integration/autoland/rev/8a13d2fac4d437dcffe98094590fa69da27f9db8

Comment 5

[Gregory Pappas [:gregp]]

Thanks, working on it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dcfab1af109
Remove MAX_OMNIBOX_RESULT_COUNT r=adw

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8dcfab1af109