1815136 - C_VerifyFinal does not return accurate error code for incorrect HMACs

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[joachim]

Steps to reproduce:

sftk_HMACCmp is used in the NSC_VerifyFinal function to finalize the result of an HMAC verification. If the return value is not SECSuccess, the PORT error is retrieved and mapped to CKR_xxx: https://github.com/nss-dev/nss/blob/master/lib/softoken/pkcs11c.c#L3840-L3842

However, sftk_HMACCmp doesn't actually set a PORT error. Consequently, sftk_MapCryptError receives garbage and returns a garbage result as well.

Actual results:

The return code of C_VerifyFinal is all over the place, e.g. CKR_ARGUMENTS_BAD or CKR_GENERAL_ERROR depending on the specific HMAC mechanism.

Expected results:

Return code CKR_SIGNATURE_INVALID.

An easy fix is to add PORT_SetError(SEC_ERROR_BAD_SIGNATURE); to the sftk_HMACCmp function.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[John Schanck [:jschanck]]

Attachment: Bug 1815136 - set PORT error after sftk_HMACCmp failure. r=#nss-reviewers

Comment 5

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/9013e616fe14c84ce447bc005c1895d75f56da1d