1815186 - Expose function that can convert color spaces to chrome

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tiaan Louw [:tlouw]]

This would allow things like devtools to convert between color formats/spaces with the calculations done on the platform side.

A use case is to implement InspectorUtils.colorTo(color, colorSpace) for use in the color picker to convert colors.

Comment 1

[Tiaan Louw [:tlouw]]

Attachment: Bug 1815186 - Add ColorTo to InspectorUtils to convert color to other color spaces. r=emilio,#layout-reviewers

This will allow calling InspectorUtils.ColorTo("red", "lab") and
receive {color: "lab(54.3 80.8 69.9)", adjusted: false}.

Adjusted is set to true if the color was adjusted to fit into the sRGB
color space.

Comment 2

[Tiaan Louw [:tlouw]]

We need the computed color values in the extended AbsoluteColor format as well as support for detecting/mapping gamut.

Comment 3

[Chris Lilley]

Adjusted is set to true if the color was adjusted to fit into the sRGB color space.

Is that for HSL/HWB? If so, that requirement is under discussion and likely to be dropped.

If it is for gamut mapping to screens, not all screens are sRGB - is there a different flag if it has been gamut mapped to, say, a P3 screen?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab9f3266184b
Add ColorTo to InspectorUtils to convert color to other color spaces. r=emilio,layout-reviewers,supply-chain-reviewers

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing failures at test_color_to.html.

Backout link

Push with failures

Failure log

Comment 6

[Tiaan Louw [:tlouw]]

Seems to be a strange Android only float serialization issue, will fix test.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28454778bc26
Add ColorTo to InspectorUtils to convert color to other color spaces. r=emilio,layout-reviewers,supply-chain-reviewers

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/28454778bc26