1815219 - Support callable function imports other than JSFunction

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P2)

Description

[Jan de Mooij [:jandem]]

According to the spec, Wasm func module imports can be any callable JS object. In SpiderMonkey we currently only support JSFunction instances and throw a LinkError for other callables such as callable proxies.

I noticed this while prototyping a different design for bound functions (bug 1812316). This matches the spec better but failed a number of Wasm tests that use bound functions.

I also confirmed Chrome and Safari support importing non-function callables (tested with a callable proxy).

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1815219 part 1 - Support callable objects other than JSFunction for Wasm imports. r?rhunt!

With this patch we use IsCallable instead of checking for the JSFunction class.
This matches the spec but requires changing a number of places to use JSObject* instead
of JSFunction*.

We still reject cross-compartment wrappers because they have some additional
complexity.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1815219 part 2 - Rename JSFunctionVector to JSObjectVector. r?rhunt!

Depends on D168946

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e52b71a29297
part 1 - Support callable objects other than JSFunction for Wasm imports. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/a0d620ed5943
part 2 - Rename JSFunctionVector to JSObjectVector. r=rhunt

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e52b71a29297
https://hg.mozilla.org/mozilla-central/rev/a0d620ed5943