1815241 - [wpt-sync] Sync PR 38369 - Fix incorrect :nth-child(... of S) with many children.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38369 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38369
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

Fix incorrect :nth-child(... of S) with many children.

When servicing :nth-child(... of S) from the cache (which happens with
more than 32 elements), we only store every third element in the cache,
but when looking up and not hitting an element exactly, we would not
properly skip siblings that don't match the selector.

Add a DCHECK to make sure we catch this earlier if similar issues
should show up in the future.

Fixed: 1412421
Change-Id: Id97d110e552760882ad0558e14980467f1017220

Reviewed-on: https://chromium-review.googlesource.com/4224392
WPT-Export-Revision: ec2a2fd006865f8c8a70c743acb28b587ecfb3b6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4f481eb65e330c144ad2f5eda2c31e57d706d2f

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94562e23984f
[wpt PR 38369] - Fix incorrect :nth-child(... of S) with many children., a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/94562e23984f