macOS search-textbox.css styles / font-sizes are a bit dubious.
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
People
(Reporter: emilio, Unassigned)
References
Details
As per https://phabricator.services.mozilla.com/D168968#inline-932390:
Fairly sure this is bogus. Looks like it's been here since bug 450800 and now it's just breaking things, e.g. in the settings, it's making the input field look substantially smaller on macOS vs. the size of all the other text on the page. It happens to be correct on the sidebar, but only because the ancestor is using font: message-box and that's smaller. If anything it should probably use a different OS font keyword rather than a fixed px size (but only in that case, not in about:preferences ).
|
||
Comment 1•3 years ago
|
||
This has presumably been wrong for 14 years. Seems low severity. Chatted with Jules a little and I think they have some suggestions for the fonts to deal with the sidebar and in-content use cases.
|
||
Comment 2•3 years ago
•
|
||
Hey - Like Gijs said in that quote, on chrome contexts 12px looks okay on macOS because message-box defaults to a font size of 11px. If we'd rather use a different OS keyword for the chrome I'd suggest using menu for the search textbox since there are already chrome contexts where we rely on menu. On macOS menu corresponds to about 13px I believe. On the sidebar instance though, I noticed there are font size overrides on top of message-box to make the tree UI into 12px as well. Maybe we could use font: menu for all of the sidebar UI if we think message-box looks too small. Looking at Finder and Mail on macOS, I feel the sidebar items are going off about a similar scale to my eye (13px and not 11px).
For about:preferences and in-content search textbox contexts we'd probably want to default to the in-content default font size of 15px.
Description
•