1815272 - Add a hidden pref to skip very large blobs

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

Right now it is too easy for fuzzers to generate test cases that allocate large blob images and OOMs, to the point that it blocks fuzzing other things.

To unblock fuzzing let's add a hidden pref that would only be used by fuzzers (and hopefully temporarily) to prevent them from quickly running into the same issues, at least until we have a handle on them.

When the pref is set and we run into a very large blob image, it would just be skipped or rendered incorrectly in whatever way is convenient, without crashing or causing large memory allocations.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

when you say large do mean bytes or dimensions?

Comment 2

[Nicolas Silva [:nical]]

Both would work. Something like visible_rect.width * visible_rect.height > threshold.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1815272 - Add a pref to restric blob image size to 2048x2048. r=#gfx-reviewers

This is an unsavoury workaround to let the fuzzing team make progress while we are sorting through our blob layerization and sizing issues.
This adds a hidden pref "gfx.webrender.debug.restrict-blob-size", which, when set to true, clamps the size of blob images to 2048x2048.
This means that bigger blobs will render incorrectly but will be less likely to cause OOMs.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ee233bdf000
Add a pref to restric blob image size to 2048x2048. r=gfx-reviewers,gw

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7ee233bdf000