1815273 - WidgetEvent::Duplicate triggers extra TimeStamp::Now() call

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]] (vacation-ish -> Aug 1)]

Unless I'm missing something
https://searchfox.org/mozilla-central/rev/ddbeacddc15008936e8f619c8c3a05fac6eab8d8/widget/BasicEvents.h#549,552 calls constructor which will initialize timestamp, but that value will be then overridden in https://searchfox.org/mozilla-central/rev/ddbeacddc15008936e8f619c8c3a05fac6eab8d8/widget/BasicEvents.h#553
Calling TimeStamp::Now() is particularly slow on linux

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, there should be a constructor which does not initialize the timestamp.

Comment 2

[Olli Pettay [:smaug][[e-mail]] (vacation-ish -> Aug 1)]

Or need to pass optional argument around

Comment 3

[Olli Pettay [:smaug][[e-mail]] (vacation-ish -> Aug 1)]

Attachment: Bug 1815273 - WidgetEvent::Duplicate triggers extra TimeStamp::Now() call, r=masayuki

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a88b93419ed9
WidgetEvent::Duplicate triggers extra TimeStamp::Now() call, r=masayuki

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a88b93419ed9