Closed Bug 1815308 Opened 2 years ago Closed 2 years ago

Differently cased pdf extensions do not trigger the display of pdfjs feature callout

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Iteration:
111.2 - Jan 30 - Feb 10
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: jprickett, Assigned: jprickett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1815308 - Changed feature callout pdf check to use content principal instead of source URI r?aminomancer,#omc-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Since the checks for .pdf in tabbrowser.js don't manipulate casing before happening, the feature callout is only ever displayed if the .pdf extension is in all lowercase. We should use something like gBrowser.contentPrincipal?.originNoSuffix === "resource://pdf.js" to eliminate edge cases surrounding extension naming, and potentially other edge cases we haven't thought of.

Attachment #9316207 - Attachment is obsolete: true
Pushed by jprickett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/296ab70af91e Changed feature callout pdf check to use content principal instead of source URI r=aminomancer,omc-reviewers

https://hg.mozilla.org/mozilla-central/rev/296ab70af91e

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: