1815314 - Add unit tests for persistent events of pageAction and browserAction in event pages on Android

Status: RESOLVED FIXED

(WebExtensions :: Android, task, P3)

Description

[Shane Caraveo (:mixedpuppy)]

The events need to be converted to support event pages. See bug 1815310 for more detail.

Comment 1

[Rob Wu [:robwu]]

What makes you believe that they are not persistent?

The mobile implementations implement ExtensionAPIPersistent, as part of bug 1748546

• https://searchfox.org/mozilla-central/rev/4fcb729dc98138af00570c0a378fbff90a167d79/mobile/android/components/extensions/ext-pageAction.js#81
• https://searchfox.org/mozilla-central/rev/4fcb729dc98138af00570c0a378fbff90a167d79/mobile/android/components/extensions/ext-browserAction.js#87

I don't see any unit tests in either of these patches, so that would be the remaining task.

It would be nice to create a mochitest in toolkit, since that runs on both desktop and Android.

Comment 2

[Rob Wu [:robwu]]

I added some tests for pageAction.onClicked, browserAction.onClicked and action.onClicked in bug 1811608.

It should be straightforward to extend them with an event page test.

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Bug 1815314 - Tests for pageAction and browserAction persistent events r=willdurand

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32efd6f8879a
Tests for pageAction and browserAction persistent events r=willdurand

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/32efd6f8879a