1815383 - `InsertTextTransaction::DoTransaction` and `ReplaceTextTransaction::DoTransaction` should stop updating `Selection` directly

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://searchfox.org/mozilla-central/rev/188d0f76a73e0671d12e744a71e9f5701668cc37/editor/libeditor/InsertTextTransaction.cpp#86

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://searchfox.org/mozilla-central/rev/08362489086b10de96e7a199b267ea5504c01583/editor/libeditor/ReplaceTextTransaction.cpp#73-74

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815383 - part 1: Make `InsertTextTransaction::DoTransaction` stop updating `Selection` directly r=m_kato!

And also this patch makes its only user,
EditorBase::InsertTextIntoTextNodeWithTransaction, and its only caller,
EditorBase::InsertTextWithTransaction, return InsertTextResult for
returning both end of inserted text and caret point suggestion. Note that
if it's for IME composition, CompositionTransaction needs to update
Selection directly. Therefore, caret point may be unset under composition
to updating Selection to wrong point (it seems that
TextEditor::HandleInsertText can be simplified later because of this change).

Depends on D169044

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815383 - part 2: Make `InsertText` and `ReplaceText` of `WhiteSpaceVisibilityKeeper` return `InsertTextResult` r=m_kato!

Depends on D169744

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1815383 - part 3: Make `ReplaceTextTransaction::DoTransaction` stop updating `Selection` directly r=m_kato!

And also this changes HTMLEditor::ReplaceTextWithTransaction which is the only
user of ReplaceTextTransaction.

Depends on D169745

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0c7ac76b5f3
part 1: Make `InsertTextTransaction::DoTransaction` stop updating `Selection` directly r=m_kato

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6af593c327b0
part 2: Make `InsertText` and `ReplaceText` of `WhiteSpaceVisibilityKeeper` return `InsertTextResult` r=m_kato

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47e6b9573249
part 3: Make `ReplaceTextTransaction::DoTransaction` stop updating `Selection` directly r=m_kato

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c0c7ac76b5f3

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6af593c327b0
https://hg.mozilla.org/mozilla-central/rev/47e6b9573249