1815421 - Clear button is active without username input on "Add login"

Status: RESOLVED FIXED

(Firefox for Android :: Logins, defect, P2)

Description

[Lorand Janos]

Steps to reproduce

1. Go to Settings>Logins and passwords>Saved logins> +Add Login
2. Observe the page
3. Without any input in the username field, tap on the clear (x) button.

Expected behavior

• The clear button from the username field is either inactive or not displayed until the user types in something (Like in the case of the password field clear button).

Actual behavior

• The clear button from the username field is active and it's greyed out on tap like something was deleted.
• There are inconsistencies between the username and password clear button functionality and UI.

Firefox version:

Nightly 111.0a1 (2023-02-07).

Android device model:

Google Pixel 7.

Android OS version:

Android 13.

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1815421 - Clear button is active without username input on `Add login` (#930)

Comment 2

[Iorga Gabriel]

The bug was fixed in this pr

Comment 3

[Lorand Janos]

This issue is still reproducible with the latest Nightly build (116.0a1 from 2023/06/29) with the following devices:

• Motorola Moto G9 plus (Android 11)
• Oppo Find X5 (Android 13)
• Google Pixel 7 Pro ( Android 14)

Reopening the ticket.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1815421 - Clear button should be active only when username input is not empty. (#2657)

Comment 5

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/23cb7cbd1b280ed069ae26785ec3c5846550ad90
[main] Bug 1815421 - Clear button should be active only when username input is not empty.

Comment 6

[Lorand Janos]

Verified as fixed on the latest Nightly build (116.0a1 from 2023-06-30).
The clear button is not active before input in the username field.
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified for 116.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.