181545 - Removal of dead code from mime

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Daniel Bratell]

There are some dead code and unused variables in mailnews/mime. A patch coming
up to remove them.

Comment 1

[Daniel Bratell]

Attachment: Just removal of some dead stuff

Comment 2

[David :Bienvenu]

you want a review from ducarroz and an sr from me or Seth.

Comment 3

[Daniel Bratell]

Comment on attachment 107180 [details] [diff] [review]
Just removal of some dead stuff

Ok, I was just grabbing mail people names out of a hat. :-)

Comment 4

[Daniel Bratell]

Comment on attachment 107180 [details] [diff] [review]
Just removal of some dead stuff

I attached the wrong file. There's a typo in mimetenr.cpp in this one. The
#ifdef should have a matching #endif. Consider it correct in my tree.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 107180 [details] [diff] [review]
Just removal of some dead stuff

please get ducarroz to review.

are you sure mime_reformat_date isn't used?

see
http://lxr.mozilla.org/mozilla/search?string=mime_reformat_date
http://lxr.mozilla.org/mozilla/search?string=reformat_date_fn



+#define
to
+#endif

Comment 6

[Jean-Francois Ducarroz]

Comment on attachment 107180 [details] [diff] [review]
Just removal of some dead stuff

R=ducarroz

Comment 7

[David :Bienvenu]

Comment on attachment 107180 [details] [diff] [review]
Just removal of some dead stuff

sr=bienvenu

Comment 8

[Daniel Bratell]

The references to mime_reformat_date that lxr finds is for a different copy of
the same function. The function I removed was |static| so it couldn't be
referenced outside the file. 

Comment 9

[Daniel Bratell]

Patch checked in.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED using LXR (and my local source-tree).